diff options
| author | Luca Ceresoli <luca.ceresoli@bootlin.com> | 2024-12-19 10:39:46 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2025-02-08 09:57:07 +0100 |
| commit | 7c86e802c6bca44bab1bfc1402d3e6f137baeeb6 (patch) | |
| tree | 11b52c73929463a8ea6d101b67b93680c6f35248 /drivers/gpio | |
| parent | de7659f01ad1ce532f599be2f81f0ec0f72d4322 (diff) | |
| download | linux-7c86e802c6bca44bab1bfc1402d3e6f137baeeb6.tar.gz linux-7c86e802c6bca44bab1bfc1402d3e6f137baeeb6.tar.bz2 linux-7c86e802c6bca44bab1bfc1402d3e6f137baeeb6.zip | |
gpio: pca953x: log an error when failing to get the reset GPIO
[ Upstream commit 7cef813a91c468253c80633891393478b9f2c966 ]
When the dirver fails getting this GPIO, it fails silently. Log an error
message to make debugging a lot easier by just reading dmesg.
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Fixes: 054ccdef8b28 ("gpio: pca953x: Add optional reset gpio control")
Link: https://lore.kernel.org/r/20241219-pca953x-log-no-reset-gpio-v1-1-9aa7bcc45ead@bootlin.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/gpio')
| -rw-r--r-- | drivers/gpio/gpio-pca953x.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c index 3f2d33ee20cc..e49802f26e07 100644 --- a/drivers/gpio/gpio-pca953x.c +++ b/drivers/gpio/gpio-pca953x.c @@ -1088,7 +1088,8 @@ static int pca953x_probe(struct i2c_client *client) */ reset_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW); if (IS_ERR(reset_gpio)) - return PTR_ERR(reset_gpio); + return dev_err_probe(dev, PTR_ERR(reset_gpio), + "Failed to get reset gpio\n"); } chip->client = client; |