diff options
author | Xiaogang Chen <xiaogang.chen@amd.com> | 2024-08-23 02:04:09 -0500 |
---|---|---|
committer | Alex Deucher <alexander.deucher@amd.com> | 2024-08-23 10:55:13 -0400 |
commit | 6ef29715ac06fad7b3e43086cb4df97952c3a4de (patch) | |
tree | 95f930c9d35a0a6a040a2a7d45a34d2aeb4b2a0f /drivers/gpu/drm/amd/amdkfd/kfd_priv.h | |
parent | 010cc730ace807c6d267481b5fb6ff99acc35c46 (diff) | |
download | linux-6ef29715ac06fad7b3e43086cb4df97952c3a4de.tar.gz linux-6ef29715ac06fad7b3e43086cb4df97952c3a4de.tar.bz2 linux-6ef29715ac06fad7b3e43086cb4df97952c3a4de.zip |
drm/amdkfd: Change kfd/svm page fault drain handling
When app unmap vm ranges(munmap) kfd/svm starts drain pending page fault and
not handle any incoming pages fault of this process until a deferred work item
got executed by default system wq. The time period of "not handle page fault"
can be long and is unpredicable. That is advese to kfd performance on page
faults recovery.
This patch uses time stamp of incoming page fault to decide to drop or recover
page fault. When app unmap vm ranges kfd records each gpu device's ih ring
current time stamp. These time stamps are used at kfd page fault recovery
routine.
Any page fault happened on unmapped ranges after unmap events is application
bug that accesses vm range after unmap. It is not driver work to cover that.
By using time stamp of page fault do not need drain page faults at deferred
work. So, the time period that kfd does not handle page faults is reduced
and can be controlled.
Signed-off-by: Xiaogang.Chen <Xiaogang.Chen@amd.com>
Reviewed-by: Philip Yang <Philip.Yang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Diffstat (limited to 'drivers/gpu/drm/amd/amdkfd/kfd_priv.h')
-rw-r--r-- | drivers/gpu/drm/amd/amdkfd/kfd_priv.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_priv.h b/drivers/gpu/drm/amd/amdkfd/kfd_priv.h index 7bba6bed2f48..9ae9abc6eb43 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_priv.h +++ b/drivers/gpu/drm/amd/amdkfd/kfd_priv.h @@ -866,6 +866,8 @@ struct svm_range_list { struct delayed_work restore_work; DECLARE_BITMAP(bitmap_supported, MAX_GPU_INSTANCE); struct task_struct *faulting_task; + /* check point ts decides if page fault recovery need be dropped */ + uint64_t checkpoint_ts[MAX_GPU_INSTANCE]; }; /* Process data */ |