diff options
| author | Jani Nikula <jani.nikula@intel.com> | 2023-12-19 12:47:46 +0200 |
|---|---|---|
| committer | Jani Nikula <jani.nikula@intel.com> | 2023-12-19 17:30:02 +0200 |
| commit | 547a720e8e8f1b2c93f29a5dbe7315e285eb73a6 (patch) | |
| tree | 3566f2754783825319038aad48a5317a60fe3071 /drivers/gpu/drm/i915/display/intel_hdcp.c | |
| parent | 4773293bc564b967e8f863e05dbcc729a58b0409 (diff) | |
| download | linux-547a720e8e8f1b2c93f29a5dbe7315e285eb73a6.tar.gz linux-547a720e8e8f1b2c93f29a5dbe7315e285eb73a6.tar.bz2 linux-547a720e8e8f1b2c93f29a5dbe7315e285eb73a6.zip | |
drm/i915/hdcp: fix intel_hdcp_get_repeater_ctl() error return value
intel_hdcp_get_repeater_ctl() is supposed to return unsigned register
contents. Returning negative error values is unexpected, and none of the
callers check for that.
Sort of fix the error cases by returning 0. I don't think we should hit
these cases anyway, and using 0 for the registers is safer than
0xffffffea (-EINVAL).
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231219104746.1065431-2-jani.nikula@intel.com
Diffstat (limited to 'drivers/gpu/drm/i915/display/intel_hdcp.c')
| -rw-r--r-- | drivers/gpu/drm/i915/display/intel_hdcp.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c index f9010094ff29..ee29fcb860e4 100644 --- a/drivers/gpu/drm/i915/display/intel_hdcp.c +++ b/drivers/gpu/drm/i915/display/intel_hdcp.c @@ -347,7 +347,7 @@ u32 intel_hdcp_get_repeater_ctl(struct drm_i915_private *i915, default: drm_err(&i915->drm, "Unknown transcoder %d\n", cpu_transcoder); - return -EINVAL; + return 0; } } @@ -364,7 +364,7 @@ u32 intel_hdcp_get_repeater_ctl(struct drm_i915_private *i915, return HDCP_DDIE_REP_PRESENT | HDCP_DDIE_SHA1_M0; default: drm_err(&i915->drm, "Unknown port %d\n", port); - return -EINVAL; + return 0; } } |