diff options
author | Hugo Villeneuve <hvilleneuve@dimonoff.com> | 2024-09-27 09:53:05 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2025-02-27 04:30:21 -0800 |
commit | d754ae423bbf28748bc1bc49c8005c2ad719935d (patch) | |
tree | c16233e2cdd54ffe3ffecc65489145ae4ba80148 /drivers/gpu/drm/lima/lima_devfreq.c | |
parent | 97621151f4a61879645b36ca8fbd9a4decb29182 (diff) | |
download | linux-d754ae423bbf28748bc1bc49c8005c2ad719935d.tar.gz linux-d754ae423bbf28748bc1bc49c8005c2ad719935d.tar.bz2 linux-d754ae423bbf28748bc1bc49c8005c2ad719935d.zip |
drm: panel: jd9365da-h3: fix reset signal polarity
commit a8972d5a49b408248294b5ecbdd0a085e4726349 upstream.
In jadard_prepare() a reset pulse is generated with the following
statements (delays ommited for clarity):
gpiod_set_value(jadard->reset, 1); --> Deassert reset
gpiod_set_value(jadard->reset, 0); --> Assert reset for 10ms
gpiod_set_value(jadard->reset, 1); --> Deassert reset
However, specifying second argument of "0" to gpiod_set_value() means to
deassert the GPIO, and "1" means to assert it. If the reset signal is
defined as GPIO_ACTIVE_LOW in the DTS, the above statements will
incorrectly generate the reset pulse (inverted) and leave it asserted
(LOW) at the end of jadard_prepare().
Fix reset behavior by inverting gpiod_set_value() second argument
in jadard_prepare(). Also modify second argument to devm_gpiod_get()
in jadard_dsi_probe() to assert the reset when probing.
Do not modify it in jadard_unprepare() as it is already properly
asserted with "1", which seems to be the intended behavior.
Fixes: 6b818c533dd8 ("drm: panel: Add Jadard JD9365DA-H3 DSI panel")
Cc: stable@vger.kernel.org
Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20240927135306.857617-1-hugo@hugovil.com
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240927135306.857617-1-hugo@hugovil.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/gpu/drm/lima/lima_devfreq.c')
0 files changed, 0 insertions, 0 deletions