diff options
| author | Jakub Kicinski <kuba@kernel.org> | 2024-04-22 16:33:10 -0700 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2024-04-22 17:15:39 -0700 |
| commit | af046fd169d43ef0d5f8006954fa4b2fc90974af (patch) | |
| tree | d4fcb4f6735b77eb6d80991252e22b3248ac4e14 /drivers/net/tap.c | |
| parent | 65f1df1140aab935c1db68abdc151dddf6fea85a (diff) | |
| parent | 65bada80dec1f2108a751644773b2120bd789934 (diff) | |
| download | linux-af046fd169d43ef0d5f8006954fa4b2fc90974af.tar.gz linux-af046fd169d43ef0d5f8006954fa4b2fc90974af.tar.bz2 linux-af046fd169d43ef0d5f8006954fa4b2fc90974af.zip | |
Merge branch 'for-uring-ubufops' into HEAD
Pavel Begunkov says:
====================
implement io_uring notification (ubuf_info) stacking (net part)
To have per request buffer notifications each zerocopy io_uring send
request allocates a new ubuf_info. However, as an skb can carry only
one uarg, it may force the stack to create many small skbs hurting
performance in many ways.
The patchset implements notification, i.e. an io_uring's ubuf_info
extension, stacking. It attempts to link ubuf_info's into a list,
allowing to have multiple of them per skb.
liburing/examples/send-zerocopy shows up 6 times performance improvement
for TCP with 4KB bytes per send, and levels it with MSG_ZEROCOPY. Without
the patchset it requires much larger sends to utilise all potential.
bytes | before | after (Kqps)
1200 | 195 | 1023
4000 | 193 | 1386
8000 | 154 | 1058
====================
Link: https://lore.kernel.org/all/cover.1713369317.git.asml.silence@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/tap.c')
| -rw-r--r-- | drivers/net/tap.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/tap.c b/drivers/net/tap.c index 9f0495e8df4d..bfdd3875fe86 100644 --- a/drivers/net/tap.c +++ b/drivers/net/tap.c @@ -754,7 +754,7 @@ static ssize_t tap_get_user(struct tap_queue *q, void *msg_control, skb_zcopy_init(skb, msg_control); } else if (msg_control) { struct ubuf_info *uarg = msg_control; - uarg->callback(NULL, uarg, false); + uarg->ops->complete(NULL, uarg, false); } dev_queue_xmit(skb); |