diff options
| author | Li RongQing <lirongqing@baidu.com> | 2024-06-21 17:45:52 +0800 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2024-06-25 16:42:26 -0700 |
| commit | d891317fe4fbe5a85522dccb66d3a159915d7983 (patch) | |
| tree | df633060dea409c7d233f13faa2983bd7a32a921 /drivers/net/virtio_net.c | |
| parent | c4532232fa2a4f8d9b9a88135a666545157f3d13 (diff) | |
| download | linux-d891317fe4fbe5a85522dccb66d3a159915d7983.tar.gz linux-d891317fe4fbe5a85522dccb66d3a159915d7983.tar.bz2 linux-d891317fe4fbe5a85522dccb66d3a159915d7983.zip | |
virtio_net: Remove u64_stats_update_begin()/end() for stats fetch
This place is fetching the stats, u64_stats_update_begin()/end()
should not be used, and the fetcher of stats is in the same context
as the updater of the stats, so don't need any protection
Suggested-by: Jakub Kicinski <kuba@kernel.org>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Li RongQing <lirongqing@baidu.com>
Link: https://lore.kernel.org/20240621094552.53469-1-lirongqing@baidu.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/virtio_net.c')
| -rw-r--r-- | drivers/net/virtio_net.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index b1f8b720733e..f21297751310 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -2382,12 +2382,13 @@ static void virtnet_rx_dim_update(struct virtnet_info *vi, struct receive_queue if (!rq->packets_in_napi) return; - u64_stats_update_begin(&rq->stats.syncp); + /* Don't need protection when fetching stats, since fetcher and + * updater of the stats are in same context + */ dim_update_sample(rq->calls, u64_stats_read(&rq->stats.packets), u64_stats_read(&rq->stats.bytes), &cur_sample); - u64_stats_update_end(&rq->stats.syncp); net_dim(&rq->dim, cur_sample); rq->packets_in_napi = 0; |