diff options
| author | Ping-Ke Shih <pkshih@realtek.com> | 2023-04-14 16:22:28 +0800 |
|---|---|---|
| committer | Kalle Valo <kvalo@kernel.org> | 2023-04-20 15:32:18 +0300 |
| commit | eaddda248483ff78c4d26f1bf420e5f2af436a74 (patch) | |
| tree | 5ae8f72ad5093c345b98450de02897da9e270325 /drivers/net/wireless/realtek/rtw89/debug.c | |
| parent | eb74bfcfa99415f1a65ce021b8ac2256b7ed50bc (diff) | |
| download | linux-eaddda248483ff78c4d26f1bf420e5f2af436a74.tar.gz linux-eaddda248483ff78c4d26f1bf420e5f2af436a74.tar.bz2 linux-eaddda248483ff78c4d26f1bf420e5f2af436a74.zip | |
wifi: rtw89: mac: use regular int as return type of DLE buffer request
The function to request DLE (data link engine) buffer uses 'u16' as return
value that mixes error code, so change it to 'int' as regular error code.
Also, treat invalid register value (0xfff) as an error.
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20230414082228.30766-1-pkshih@realtek.com
Diffstat (limited to 'drivers/net/wireless/realtek/rtw89/debug.c')
| -rw-r--r-- | drivers/net/wireless/realtek/rtw89/debug.c | 13 |
1 files changed, 4 insertions, 9 deletions
diff --git a/drivers/net/wireless/realtek/rtw89/debug.c b/drivers/net/wireless/realtek/rtw89/debug.c index 0e0e1483c099..1e5b7a998716 100644 --- a/drivers/net/wireless/realtek/rtw89/debug.c +++ b/drivers/net/wireless/realtek/rtw89/debug.c @@ -3069,18 +3069,13 @@ static int rtw89_dbg_trigger_ctrl_error(struct rtw89_dev *rtwdev) { struct rtw89_cpuio_ctrl ctrl_para = {0}; u16 pkt_id; + int ret; rtw89_leave_ps_mode(rtwdev); - pkt_id = rtw89_mac_dle_buf_req(rtwdev, 0x20, true); - switch (pkt_id) { - case 0xffff: - return -ETIMEDOUT; - case 0xfff: - return -ENOMEM; - default: - break; - } + ret = rtw89_mac_dle_buf_req(rtwdev, 0x20, true, &pkt_id); + if (ret) + return ret; /* intentionally, enqueue two pkt, but has only one pkt id */ ctrl_para.cmd_type = CPUIO_OP_CMD_ENQ_TO_HEAD; |