diff options
| author | Liang Chen <liangchen.linux@gmail.com> | 2023-09-01 12:09:21 +0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2023-09-04 06:52:39 +0100 |
| commit | 151e887d8ff97e2e42110ffa1fb1e6a2128fb364 (patch) | |
| tree | 89755d42a91ace824bd8bfda2d634ba75820ce69 /drivers/net | |
| parent | 817c7cd2043a83a3d8147f40eea1505ac7300b62 (diff) | |
| download | linux-151e887d8ff97e2e42110ffa1fb1e6a2128fb364.tar.gz linux-151e887d8ff97e2e42110ffa1fb1e6a2128fb364.tar.bz2 linux-151e887d8ff97e2e42110ffa1fb1e6a2128fb364.zip | |
veth: Fixing transmit return status for dropped packets
The veth_xmit function returns NETDEV_TX_OK even when packets are dropped.
This behavior leads to incorrect calculations of statistics counts, as
well as things like txq->trans_start updates.
Fixes: e314dbdc1c0d ("[NET]: Virtual ethernet device driver.")
Signed-off-by: Liang Chen <liangchen.linux@gmail.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/veth.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/veth.c b/drivers/net/veth.c index d43e62ebc2fc..9c6f4f83f22b 100644 --- a/drivers/net/veth.c +++ b/drivers/net/veth.c @@ -344,6 +344,7 @@ static netdev_tx_t veth_xmit(struct sk_buff *skb, struct net_device *dev) { struct veth_priv *rcv_priv, *priv = netdev_priv(dev); struct veth_rq *rq = NULL; + int ret = NETDEV_TX_OK; struct net_device *rcv; int length = skb->len; bool use_napi = false; @@ -378,11 +379,12 @@ static netdev_tx_t veth_xmit(struct sk_buff *skb, struct net_device *dev) } else { drop: atomic64_inc(&priv->dropped); + ret = NET_XMIT_DROP; } rcu_read_unlock(); - return NETDEV_TX_OK; + return ret; } static u64 veth_stats_tx(struct net_device *dev, u64 *packets, u64 *bytes) |