diff options
| author | Zijun Hu <quic_zijuhu@quicinc.com> | 2024-12-06 08:52:30 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-12-27 14:02:19 +0100 |
| commit | adc4b70fb659a80a78ff3f41e88070ed195df5ba (patch) | |
| tree | a0b72b9e4a23789c852b7ceb3781a1b30e3f9932 /drivers/of | |
| parent | c62318587c06f4788664aa7a8203db1f20906c4b (diff) | |
| download | linux-adc4b70fb659a80a78ff3f41e88070ed195df5ba.tar.gz linux-adc4b70fb659a80a78ff3f41e88070ed195df5ba.tar.bz2 linux-adc4b70fb659a80a78ff3f41e88070ed195df5ba.zip | |
of: Fix refcount leakage for OF node returned by __of_get_dma_parent()
commit 5d009e024056ded20c5bb1583146b833b23bbd5a upstream.
__of_get_dma_parent() returns OF device node @args.np, but the node's
refcount is increased twice, by both of_parse_phandle_with_args() and
of_node_get(), so causes refcount leakage for the node.
Fix by directly returning the node got by of_parse_phandle_with_args().
Fixes: f83a6e5dea6c ("of: address: Add support for the parent DMA bus")
Cc: stable@vger.kernel.org
Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
Link: https://lore.kernel.org/r/20241206-of_core_fix-v1-4-dc28ed56bec3@quicinc.com
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/of')
| -rw-r--r-- | drivers/of/address.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/of/address.c b/drivers/of/address.c index b3479586bd4d..a565b8c91da5 100644 --- a/drivers/of/address.c +++ b/drivers/of/address.c @@ -616,7 +616,7 @@ struct device_node *__of_get_dma_parent(const struct device_node *np) if (ret < 0) return of_get_parent(np); - return of_node_get(args.np); + return args.np; } #endif |