diff options
| author | Zhang Qilong <zhangqilong3@huawei.com> | 2020-11-06 09:52:17 +0800 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2020-11-06 10:54:49 +0000 |
| commit | 900ccdcb79bb61471df1566a70b2b39687a628d5 (patch) | |
| tree | 5ed93275163a64205dadee8f29a29d66afbd1c52 /drivers/spi/spi-stm32.c | |
| parent | c02bb16b0e826bf0e19aa42c3ae60ea339f32cf5 (diff) | |
| download | linux-900ccdcb79bb61471df1566a70b2b39687a628d5.tar.gz linux-900ccdcb79bb61471df1566a70b2b39687a628d5.tar.bz2 linux-900ccdcb79bb61471df1566a70b2b39687a628d5.zip | |
spi: stm32: fix reference leak in stm32_spi_resume
pm_runtime_get_sync will increment pm usage counter even it
failed. Forgetting to pm_runtime_put_noidle will result in
reference leak in stm32_spi_resume, so we should fix it.
Fixes: db96bf976a4fc ("spi: stm32: fixes suspend/resume management")
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Reviewed-by: Alain Volmat <alain.volmat@st.com>
Link: https://lore.kernel.org/r/20201106015217.140476-1-zhangqilong3@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi/spi-stm32.c')
| -rw-r--r-- | drivers/spi/spi-stm32.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/spi/spi-stm32.c b/drivers/spi/spi-stm32.c index 2cc850eb8922..471dedf3d339 100644 --- a/drivers/spi/spi-stm32.c +++ b/drivers/spi/spi-stm32.c @@ -2062,6 +2062,7 @@ static int stm32_spi_resume(struct device *dev) ret = pm_runtime_get_sync(dev); if (ret < 0) { + pm_runtime_put_noidle(dev); dev_err(dev, "Unable to power device:%d\n", ret); return ret; } |