diff options
| author | Ma Ke <make24@iscas.ac.cn> | 2024-07-24 16:40:47 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-10-04 16:29:01 +0200 |
| commit | 1b08f7b5f56d1ac8150bc084e9999b3abf5431fa (patch) | |
| tree | 4ca393682f259f020fdb66f06a7691f38a693db9 /drivers/spi | |
| parent | 80f5bfbb80ea1615290dbc24f49d3d8c86db58fe (diff) | |
| download | linux-1b08f7b5f56d1ac8150bc084e9999b3abf5431fa.tar.gz linux-1b08f7b5f56d1ac8150bc084e9999b3abf5431fa.tar.bz2 linux-1b08f7b5f56d1ac8150bc084e9999b3abf5431fa.zip | |
spi: ppc4xx: handle irq_of_parse_and_map() errors
[ Upstream commit 0f245463b01ea254ae90e1d0389e90b0e7d8dc75 ]
Zero and negative number is not a valid IRQ for in-kernel code and the
irq_of_parse_and_map() function returns zero on error. So this check for
valid IRQs should only accept values > 0.
Fixes: 44dab88e7cc9 ("spi: add spi_ppc4xx driver")
Signed-off-by: Ma Ke <make24@iscas.ac.cn>
Link: https://patch.msgid.link/20240724084047.1506084-1-make24@iscas.ac.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/spi')
| -rw-r--r-- | drivers/spi/spi-ppc4xx.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/spi/spi-ppc4xx.c b/drivers/spi/spi-ppc4xx.c index e982d3189fdc..0d698580194e 100644 --- a/drivers/spi/spi-ppc4xx.c +++ b/drivers/spi/spi-ppc4xx.c @@ -411,6 +411,9 @@ static int spi_ppc4xx_of_probe(struct platform_device *op) /* Request IRQ */ hw->irqnum = irq_of_parse_and_map(np, 0); + if (hw->irqnum <= 0) + goto free_host; + ret = request_irq(hw->irqnum, spi_ppc4xx_int, 0, "spi_ppc4xx_of", (void *)hw); if (ret) { |