diff options
| author | Vamshi Gajjela <vamshigajjela@google.com> | 2024-05-07 14:07:41 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-06-21 14:38:40 +0200 |
| commit | 591d5b12f8147cc88cc9c2b21740c6166d36c817 (patch) | |
| tree | df19c04b0d81c08cb21f2c14b76b642d8e7db85b /drivers/spmi | |
| parent | e293c6b38ac9029d76ff0d2a6b2d74131709a9a8 (diff) | |
| download | linux-591d5b12f8147cc88cc9c2b21740c6166d36c817.tar.gz linux-591d5b12f8147cc88cc9c2b21740c6166d36c817.tar.bz2 linux-591d5b12f8147cc88cc9c2b21740c6166d36c817.zip | |
spmi: hisi-spmi-controller: Do not override device identifier
commit eda4923d78d634482227c0b189d9b7ca18824146 upstream.
'nr' member of struct spmi_controller, which serves as an identifier
for the controller/bus. This value is a dynamic ID assigned in
spmi_controller_alloc, and overriding it from the driver results in an
ida_free error "ida_free called for id=xx which is not allocated".
Signed-off-by: Vamshi Gajjela <vamshigajjela@google.com>
Fixes: 70f59c90c819 ("staging: spmi: add Hikey 970 SPMI controller driver")
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20240228185116.1269-1-vamshigajjela@google.com
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Link: https://lore.kernel.org/r/20240507210809.3479953-5-sboyd@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/spmi')
| -rw-r--r-- | drivers/spmi/hisi-spmi-controller.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/spmi/hisi-spmi-controller.c b/drivers/spmi/hisi-spmi-controller.c index 9cbd473487cb..6eea83ee779d 100644 --- a/drivers/spmi/hisi-spmi-controller.c +++ b/drivers/spmi/hisi-spmi-controller.c @@ -303,7 +303,6 @@ static int spmi_controller_probe(struct platform_device *pdev) spin_lock_init(&spmi_controller->lock); - ctrl->nr = spmi_controller->channel; ctrl->dev.parent = pdev->dev.parent; ctrl->dev.of_node = of_node_get(pdev->dev.of_node); |