diff options
| author | Julia Lawall <Julia.Lawall@lip6.fr> | 2015-04-04 16:59:30 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2015-04-30 16:52:21 +0200 |
| commit | bd7de5cea225f85b218730eddf7476dd6260bafc (patch) | |
| tree | 0bd0944eb028420f2c46e1dad7e051a72ed36dce /drivers/staging/emxx_udc | |
| parent | 27cbc73aac0d82490e2a6fd6838d21e8c08b0166 (diff) | |
| download | linux-bd7de5cea225f85b218730eddf7476dd6260bafc.tar.gz linux-bd7de5cea225f85b218730eddf7476dd6260bafc.tar.bz2 linux-bd7de5cea225f85b218730eddf7476dd6260bafc.zip | |
staging: emxx_udc: test returned value
Put NULL test on the result of the previous call instead on one of its
arguments. A simplified version of the semantic match that finds this
problem is as follows (http://coccinelle.lip6.fr/):
// <smpl>
r@
expression *e1;
expression *e2;
identifier f;
statement S1,S2;
@@
e1 = f(...,e2,...);
(
if (e1 == NULL || ...) S1 else S2
|
*if (e2 == NULL || ...) S1 else S2
)
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/emxx_udc')
| -rw-r--r-- | drivers/staging/emxx_udc/emxx_udc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c index fbf82bc735cf..7de1e9ec2267 100644 --- a/drivers/staging/emxx_udc/emxx_udc.c +++ b/drivers/staging/emxx_udc/emxx_udc.c @@ -2998,7 +2998,7 @@ static void nbu2ss_ep_fifo_flush(struct usb_ep *_ep) } ep = container_of(_ep, struct nbu2ss_ep, ep); - if (!_ep) { + if (!ep) { pr_err("udc: %s, bad ep\n", __func__); return; } |