diff options
| author | Johan Hovold <johan@kernel.org> | 2021-04-08 17:08:59 +0200 |
|---|---|---|
| committer | Johan Hovold <johan@kernel.org> | 2021-04-09 17:55:21 +0200 |
| commit | 07125072b0a08a13331b46990ea48997fa0c64b4 (patch) | |
| tree | ff112a2392265c25e91f21c84045d90b00e6f9c1 /drivers/usb/serial/upd78f0730.c | |
| parent | f8edbd5186548e670bfb583cd2ad90f3e203a010 (diff) | |
| download | linux-07125072b0a08a13331b46990ea48997fa0c64b4.tar.gz linux-07125072b0a08a13331b46990ea48997fa0c64b4.tar.bz2 linux-07125072b0a08a13331b46990ea48997fa0c64b4.zip | |
USB: serial: do not use tty class device for debugging
Use the port struct device rather than tty class device for debugging.
Note that while USB serial doesn't support serdev yet (due to serdev not
handling hotplugging), serdev ttys do not have a corresponding class
device and would have been logged using a "(NULL device *):" prefix.
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
Diffstat (limited to 'drivers/usb/serial/upd78f0730.c')
| -rw-r--r-- | drivers/usb/serial/upd78f0730.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/drivers/usb/serial/upd78f0730.c b/drivers/usb/serial/upd78f0730.c index 26d7b003b7e3..63d4a784ae45 100644 --- a/drivers/usb/serial/upd78f0730.c +++ b/drivers/usb/serial/upd78f0730.c @@ -182,7 +182,6 @@ static void upd78f0730_port_remove(struct usb_serial_port *port) static int upd78f0730_tiocmget(struct tty_struct *tty) { - struct device *dev = tty->dev; struct upd78f0730_port_private *private; struct usb_serial_port *port = tty->driver_data; int signals; @@ -197,7 +196,7 @@ static int upd78f0730_tiocmget(struct tty_struct *tty) res = ((signals & UPD78F0730_DTR) ? TIOCM_DTR : 0) | ((signals & UPD78F0730_RTS) ? TIOCM_RTS : 0); - dev_dbg(dev, "%s - res = %x\n", __func__, res); + dev_dbg(&port->dev, "%s - res = %x\n", __func__, res); return res; } @@ -205,10 +204,10 @@ static int upd78f0730_tiocmget(struct tty_struct *tty) static int upd78f0730_tiocmset(struct tty_struct *tty, unsigned int set, unsigned int clear) { - struct device *dev = tty->dev; struct usb_serial_port *port = tty->driver_data; struct upd78f0730_port_private *private; struct upd78f0730_set_dtr_rts request; + struct device *dev = &port->dev; int res; private = usb_get_serial_port_data(port); @@ -241,10 +240,10 @@ static int upd78f0730_tiocmset(struct tty_struct *tty, static void upd78f0730_break_ctl(struct tty_struct *tty, int break_state) { - struct device *dev = tty->dev; struct upd78f0730_port_private *private; struct usb_serial_port *port = tty->driver_data; struct upd78f0730_set_dtr_rts request; + struct device *dev = &port->dev; private = usb_get_serial_port_data(port); |