diff options
| author | Filipe Manana <fdmanana@suse.com> | 2023-03-21 11:13:58 +0000 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2023-04-17 18:01:20 +0200 |
| commit | 5630e2bcfe22392611a88a2a1e6240ff910c480c (patch) | |
| tree | 023f95f14b762e015b0f719bd1c964588efefea5 /fs/btrfs/inode.c | |
| parent | ba4ec8fbce6c8b629a26d78cdd4a308cd0a503ca (diff) | |
| download | linux-5630e2bcfe22392611a88a2a1e6240ff910c480c.tar.gz linux-5630e2bcfe22392611a88a2a1e6240ff910c480c.tar.bz2 linux-5630e2bcfe22392611a88a2a1e6240ff910c480c.zip | |
btrfs: use a constant for the number of metadata units needed for an unlink
Instead of hard coding the number of metadata units for an unlink operation
in a couple places, define a macro and use it instead. This eliminates the
problem of one place getting out of sync with the other, such as recently
fixed by the previous patch in the series ("btrfs: fix calculation of the
global block reserve's size").
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/inode.c')
| -rw-r--r-- | fs/btrfs/inode.c | 11 |
1 files changed, 2 insertions, 9 deletions
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index 2e181a0a6f37..0b3710d47dd0 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -4248,15 +4248,8 @@ static struct btrfs_trans_handle *__unlink_start_trans(struct btrfs_inode *dir) { struct btrfs_root *root = dir->root; - /* - * 1 for the possible orphan item - * 1 for the dir item - * 1 for the dir index - * 1 for the inode ref - * 1 for the inode - * 1 for the parent inode - */ - return btrfs_start_transaction_fallback_global_rsv(root, 6); + return btrfs_start_transaction_fallback_global_rsv(root, + BTRFS_UNLINK_METADATA_UNITS); } static int btrfs_unlink(struct inode *dir, struct dentry *dentry) |