summaryrefslogtreecommitdiff
path: root/include/drm/drm_panel.h
diff options
context:
space:
mode:
authorArnd Bergmann <arnd@arndb.de>2020-01-08 14:51:05 +0100
committerSam Ravnborg <sam@ravnborg.org>2020-01-12 21:11:57 +0100
commitdba9bf0a98c5fcfb3f616bf2446d5aeef67b632c (patch)
treeac03c1453fd280f0f650d94a57175eb438dc81a1 /include/drm/drm_panel.h
parent0980939d2a7065e2264022b8b7492a85e7549101 (diff)
downloadlinux-dba9bf0a98c5fcfb3f616bf2446d5aeef67b632c.tar.gz
linux-dba9bf0a98c5fcfb3f616bf2446d5aeef67b632c.tar.bz2
linux-dba9bf0a98c5fcfb3f616bf2446d5aeef67b632c.zip
drm: panel: fix excessive stack usage in td028ttec1_prepare
With gcc -O3 in combination with the structleak plug, the compiler can inline very aggressively, leading to rather large stack usage: drivers/gpu/drm/panel/panel-tpo-td028ttec1.c: In function 'td028ttec1_prepare': drivers/gpu/drm/panel/panel-tpo-td028ttec1.c:233:1: error: the frame size of 2768 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] } Marking jbt_reg_write_*() as noinline avoids the case where multiple instances of this function get inlined into the same stack frame and each one adds a copy of 'tx_buf'. The compiler is clearly making some bad decisions here, but I did not open a new bug report as this only happens in combination with the structleak plugin. This fixes mmtom ("init/Kconfig: enable -O3 for all arches") Link: https://lore.kernel.org/lkml/CAK8P3a3jAnFZA3GFRtdYdg1-i-oih3pOQzkkrK-X3BGsFrMiZQ@mail.gmail.com/ Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Sam Ravnborg <sam@ravnborg.org> [fix indent] Link: https://patchwork.freedesktop.org/patch/msgid/20200108135116.3687988-1-arnd@arndb.de
Diffstat (limited to 'include/drm/drm_panel.h')
0 files changed, 0 insertions, 0 deletions