diff options
| author | Abhishek Pandit-Subedi <abhishekpandit@chromium.org> | 2024-05-10 20:12:41 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-06-04 15:44:27 +0200 |
| commit | 99516f76db48e1a9d54cdfed63c1babcee4e71a5 (patch) | |
| tree | b0a53e4323791c2c597816f1a28cc0cd0dd56c4b /include/linux/usb/typec.h | |
| parent | 4cb9f2c5a2df12355d0cbfdfaecc9221779d2eff (diff) | |
| download | linux-99516f76db48e1a9d54cdfed63c1babcee4e71a5.tar.gz linux-99516f76db48e1a9d54cdfed63c1babcee4e71a5.tar.bz2 linux-99516f76db48e1a9d54cdfed63c1babcee4e71a5.zip | |
usb: typec: ucsi: Fix null pointer dereference in trace
ucsi_register_altmode checks IS_ERR for the alt pointer and treats
NULL as valid. When CONFIG_TYPEC_DP_ALTMODE is not enabled,
ucsi_register_displayport returns NULL which causes a NULL pointer
dereference in trace. Rather than return NULL, call
typec_port_register_altmode to register DisplayPort alternate mode
as a non-controllable mode when CONFIG_TYPEC_DP_ALTMODE is not enabled.
Reviewed-by: Benson Leung <bleung@chromium.org>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
Signed-off-by: Jameson Thies <jthies@google.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20240510201244.2968152-2-jthies@google.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'include/linux/usb/typec.h')
0 files changed, 0 insertions, 0 deletions