summaryrefslogtreecommitdiff
path: root/include
diff options
context:
space:
mode:
authorMikel Rychliski <mikel@mikelr.com>2024-09-30 16:26:54 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2024-11-01 01:58:28 +0100
commit6bc24db74fe4788cc7c2f30a113fc6aafba225a3 (patch)
treef7b2ac74242ad7d4b629e440a28707a7e1bdf62b /include
parentf475d8a0cca76da393c361932f5fd26cda75236b (diff)
downloadlinux-6bc24db74fe4788cc7c2f30a113fc6aafba225a3.tar.gz
linux-6bc24db74fe4788cc7c2f30a113fc6aafba225a3.tar.bz2
linux-6bc24db74fe4788cc7c2f30a113fc6aafba225a3.zip
tracing/probes: Fix MAX_TRACE_ARGS limit handling
[ Upstream commit 73f35080477e893aa6f4c8d388352b871b288fbc ] When creating a trace_probe we would set nr_args prior to truncating the arguments to MAX_TRACE_ARGS. However, we would only initialize arguments up to the limit. This caused invalid memory access when attempting to set up probes with more than 128 fetchargs. BUG: kernel NULL pointer dereference, address: 0000000000000020 #PF: supervisor read access in kernel mode #PF: error_code(0x0000) - not-present page PGD 0 P4D 0 Oops: Oops: 0000 [#1] PREEMPT SMP PTI CPU: 0 UID: 0 PID: 1769 Comm: cat Not tainted 6.11.0-rc7+ #8 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.3-1.fc39 04/01/2014 RIP: 0010:__set_print_fmt+0x134/0x330 Resolve the issue by applying the MAX_TRACE_ARGS limit earlier. Return an error when there are too many arguments instead of silently truncating. Link: https://lore.kernel.org/all/20240930202656.292869-1-mikel@mikelr.com/ Fixes: 035ba76014c0 ("tracing/probes: cleanup: Set trace_probe::nr_args at trace_probe_init") Signed-off-by: Mikel Rychliski <mikel@mikelr.com> Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions