diff options
| author | Willem de Bruijn <willemb@google.com> | 2025-02-04 11:10:06 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2025-02-17 10:05:02 +0100 |
| commit | e36364d5d4344eddc3a25b4f2e0a3876ec1de82f (patch) | |
| tree | 5b1eefab4fb2eaa7d2467ccade9d9f90d67d6051 /include | |
| parent | 6312555249082d6d8cc5321ff725df05482d8b83 (diff) | |
| download | linux-e36364d5d4344eddc3a25b4f2e0a3876ec1de82f.tar.gz linux-e36364d5d4344eddc3a25b4f2e0a3876ec1de82f.tar.bz2 linux-e36364d5d4344eddc3a25b4f2e0a3876ec1de82f.zip | |
tun: revert fix group permission check
[ Upstream commit a70c7b3cbc0688016810bb2e0b9b8a0d6a530045 ]
This reverts commit 3ca459eaba1bf96a8c7878de84fa8872259a01e3.
The blamed commit caused a regression when neither tun->owner nor
tun->group is set. This is intended to be allowed, but now requires
CAP_NET_ADMIN.
Discussion in the referenced thread pointed out that the original
issue that prompted this patch can be resolved in userspace.
The relaxed access control may also make a device accessible when it
previously wasn't, while existing users may depend on it to not be.
This is a clean pure git revert, except for fixing the indentation on
the gid_valid line that checkpatch correctly flagged.
Fixes: 3ca459eaba1b ("tun: fix group permission check")
Link: https://lore.kernel.org/netdev/CAFqZXNtkCBT4f+PwyVRmQGoT3p1eVa01fCG_aNtpt6dakXncUg@mail.gmail.com/
Signed-off-by: Willem de Bruijn <willemb@google.com>
Cc: Ondrej Mosnacek <omosnace@redhat.com>
Cc: Stas Sergeev <stsp2@yandex.ru>
Link: https://patch.msgid.link/20250204161015.739430-1-willemdebruijn.kernel@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions