diff options
| author | Javier Carrasco <javier.carrasco.cruz@gmail.com> | 2024-10-14 10:56:37 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-12-05 14:03:01 +0100 |
| commit | 7d4fb115fbf17f9ffe8f82f7691df8be2f1b06bb (patch) | |
| tree | 3e844a8cef277d3e857611ae6164b250e3903d93 /init | |
| parent | 70777a23a54e359cfdfafc625a57cd56434f3859 (diff) | |
| download | linux-7d4fb115fbf17f9ffe8f82f7691df8be2f1b06bb.tar.gz linux-7d4fb115fbf17f9ffe8f82f7691df8be2f1b06bb.tar.bz2 linux-7d4fb115fbf17f9ffe8f82f7691df8be2f1b06bb.zip | |
staging: vchiq_arm: Fix missing refcount decrement in error path for fw_node
commit 22a3703af127e897dc7df89372b85bb9dc331c5f upstream.
An error path was introduced without including the required call to
of_node_put() to decrement the node's refcount and avoid leaking memory.
If the call to kzalloc() for 'mgmt' fails, the probe returns without
decrementing the refcount.
Use the automatic cleanup facility to fix the bug and protect the code
against new error paths where the call to of_node_put() might be missing
again.
Cc: stable@vger.kernel.org
Fixes: 1c9e16b73166 ("staging: vc04_services: vchiq_arm: Split driver static and runtime data")
Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
Link: https://lore.kernel.org/r/20241014-vchiq_arm-of_node_put-v2-2-cafe0a4c2666@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'init')
0 files changed, 0 insertions, 0 deletions