diff options
| author | Yunshui Jiang <jiangyunshui@kylinos.cn> | 2024-05-31 16:07:39 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-07-25 09:49:17 +0200 |
| commit | 0e91aefe13c40d74f0e95a7c555ec991f247a7a4 (patch) | |
| tree | 4b4a73c9239b65e1c3379ba526c67e4026158540 /net | |
| parent | 6440b4788b0bba9167149a1975f189f792504b13 (diff) | |
| download | linux-0e91aefe13c40d74f0e95a7c555ec991f247a7a4.tar.gz linux-0e91aefe13c40d74f0e95a7c555ec991f247a7a4.tar.bz2 linux-0e91aefe13c40d74f0e95a7c555ec991f247a7a4.zip | |
net: mac802154: Fix racy device stats updates by DEV_STATS_INC() and DEV_STATS_ADD()
[ Upstream commit b8ec0dc3845f6c9089573cb5c2c4b05f7fc10728 ]
mac802154 devices update their dev->stats fields locklessly. Therefore
these counters should be updated atomically. Adopt SMP safe DEV_STATS_INC()
and DEV_STATS_ADD() to achieve this.
Signed-off-by: Yunshui Jiang <jiangyunshui@kylinos.cn>
Message-ID: <20240531080739.2608969-1-jiangyunshui@kylinos.cn>
Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'net')
| -rw-r--r-- | net/mac802154/tx.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/net/mac802154/tx.c b/net/mac802154/tx.c index c829e4a75325..7cea95d0b78f 100644 --- a/net/mac802154/tx.c +++ b/net/mac802154/tx.c @@ -34,8 +34,8 @@ void ieee802154_xmit_worker(struct work_struct *work) if (res) goto err_tx; - dev->stats.tx_packets++; - dev->stats.tx_bytes += skb->len; + DEV_STATS_INC(dev, tx_packets); + DEV_STATS_ADD(dev, tx_bytes, skb->len); ieee802154_xmit_complete(&local->hw, skb, false); @@ -86,8 +86,8 @@ ieee802154_tx(struct ieee802154_local *local, struct sk_buff *skb) goto err_tx; } - dev->stats.tx_packets++; - dev->stats.tx_bytes += len; + DEV_STATS_INC(dev, tx_packets); + DEV_STATS_ADD(dev, tx_bytes, len); } else { local->tx_skb = skb; queue_work(local->workqueue, &local->tx_work); |