diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2024-10-17 23:34:16 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2025-02-08 09:58:17 +0100 |
| commit | 6e601a64f7777e2f78c02db1a8b5ba3b7c5e9e31 (patch) | |
| tree | 2c2f7cb85c357ddee7e6c79d1ca97d83159becce /scripts/basic | |
| parent | 278a98f6d8a7bbe1110433b057333536e4490edf (diff) | |
| download | linux-6e601a64f7777e2f78c02db1a8b5ba3b7c5e9e31.tar.gz linux-6e601a64f7777e2f78c02db1a8b5ba3b7c5e9e31.tar.bz2 linux-6e601a64f7777e2f78c02db1a8b5ba3b7c5e9e31.zip | |
media: imx-jpeg: Fix potential error pointer dereference in detach_pm()
commit 1378ffec30367233152b7dbf4fa6a25ee98585d1 upstream.
The proble is on the first line:
if (jpeg->pd_dev[i] && !pm_runtime_suspended(jpeg->pd_dev[i]))
If jpeg->pd_dev[i] is an error pointer, then passing it to
pm_runtime_suspended() will lead to an Oops. The other conditions
check for both error pointers and NULL, but it would be more clear to
use the IS_ERR_OR_NULL() check for that.
Fixes: fd0af4cd35da ("media: imx-jpeg: Ensure power suppliers be suspended before detach them")
Cc: <stable@vger.kernel.org>
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Ming Qian <ming.qian@nxp.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'scripts/basic')
0 files changed, 0 insertions, 0 deletions