diff options
| author | Samasth Norway Ananda <samasth.norway.ananda@oracle.com> | 2024-02-13 16:19:56 -0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-04-13 13:07:31 +0200 |
| commit | cf21eb6a9fc2c0d7e529f4c0dfb59fa895bab44a (patch) | |
| tree | ed5d9852121661004a1a089952bd1e9b37e321a7 /tools/power | |
| parent | ec7256887d072f98c42cdbef4dcc80ddf84c7a70 (diff) | |
| download | linux-cf21eb6a9fc2c0d7e529f4c0dfb59fa895bab44a.tar.gz linux-cf21eb6a9fc2c0d7e529f4c0dfb59fa895bab44a.tar.bz2 linux-cf21eb6a9fc2c0d7e529f4c0dfb59fa895bab44a.zip | |
tools/power x86_energy_perf_policy: Fix file leak in get_pkg_num()
[ Upstream commit f85450f134f0b4ca7e042dc3dc89155656a2299d ]
In function get_pkg_num() if fopen_or_die() succeeds it returns a file
pointer to be used. But fclose() is never called before returning from
the function.
Signed-off-by: Samasth Norway Ananda <samasth.norway.ananda@oracle.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'tools/power')
| -rw-r--r-- | tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c b/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c index 5fd9e594079c..ebda9c366b2b 100644 --- a/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c +++ b/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c @@ -1241,6 +1241,7 @@ unsigned int get_pkg_num(int cpu) retval = fscanf(fp, "%d\n", &pkg); if (retval != 1) errx(1, "%s: failed to parse", pathname); + fclose(fp); return pkg; } |