summaryrefslogtreecommitdiff
path: root/tools/testing
diff options
context:
space:
mode:
authorMark Brown <broonie@kernel.org>2024-11-11 16:18:55 +0000
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2024-12-14 20:03:36 +0100
commit2e996ea42ba24fb2829d5e6c6eacd2315439bea9 (patch)
tree8e427af50662199818db97c5ab465dad4752d34b /tools/testing
parent597d2e04659c3edda176efd6817fef4c9d029cdd (diff)
downloadlinux-2e996ea42ba24fb2829d5e6c6eacd2315439bea9.tar.gz
linux-2e996ea42ba24fb2829d5e6c6eacd2315439bea9.tar.bz2
linux-2e996ea42ba24fb2829d5e6c6eacd2315439bea9.zip
kselftest/arm64: Don't leak pipe fds in pac.exec_sign_all()
[ Upstream commit 27141b690547da5650a420f26ec369ba142a9ebb ] The PAC exec_sign_all() test spawns some child processes, creating pipes to be stdin and stdout for the child. It cleans up most of the file descriptors that are created as part of this but neglects to clean up the parent end of the child stdin and stdout. Add the missing close() calls. Signed-off-by: Mark Brown <broonie@kernel.org> Link: https://lore.kernel.org/r/20241111-arm64-pac-test-collisions-v1-1-171875f37e44@kernel.org Signed-off-by: Catalin Marinas <catalin.marinas@arm.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'tools/testing')
-rw-r--r--tools/testing/selftests/arm64/pauth/pac.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/tools/testing/selftests/arm64/pauth/pac.c b/tools/testing/selftests/arm64/pauth/pac.c
index b743daa772f5..5a07b3958fbf 100644
--- a/tools/testing/selftests/arm64/pauth/pac.c
+++ b/tools/testing/selftests/arm64/pauth/pac.c
@@ -182,6 +182,9 @@ int exec_sign_all(struct signatures *signed_vals, size_t val)
return -1;
}
+ close(new_stdin[1]);
+ close(new_stdout[0]);
+
return 0;
}