summaryrefslogtreecommitdiff
path: root/tools/testing
diff options
context:
space:
mode:
authorLijo Lazar <lijo.lazar@amd.com>2024-11-05 10:30:20 +0530
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2024-12-05 14:01:56 +0100
commit4a1db2a301749c15683085720decf317372dbbf0 (patch)
tree9e656493288d6d5325980e182cb2b3c7b33362d3 /tools/testing
parent27eaeebd6c1c9d64cd0d2b43fe7339ab465134de (diff)
downloadlinux-4a1db2a301749c15683085720decf317372dbbf0.tar.gz
linux-4a1db2a301749c15683085720decf317372dbbf0.tar.bz2
linux-4a1db2a301749c15683085720decf317372dbbf0.zip
drm/amdgpu: Fix map/unmap queue logic
[ Upstream commit fa31798582882740f2b13d19e1bd43b4ef918e2f ] In current logic, it calls ring_alloc followed by a ring_test. ring_test in turn will call another ring_alloc. This is illegal usage as a ring_alloc is expected to be closed properly with a ring_commit. Change to commit the map/unmap queue packet first followed by a ring_test. Add a comment about the usage of ring_test. Also, reorder the current pre-condition checks of job hang or kiq ring scheduler not ready. Without them being met, it is not useful to attempt ring or memory allocations. Fixes tag refers to the original patch which introduced this issue which then got carried over into newer code. Signed-off-by: Lijo Lazar <lijo.lazar@amd.com> Reviewed-by: Le Ma <le.ma@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> Fixes: 6c10b5cc4eaa ("drm/amdgpu: Remove duplicate code in gfx_v8_0.c") Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'tools/testing')
0 files changed, 0 insertions, 0 deletions