diff options
| author | Joseph Sutton <josephsutton@catalyst.net.nz> | 2023-08-01 09:56:49 +1200 |
|---|---|---|
| committer | Andrew Bartlett <abartlet@samba.org> | 2023-08-08 04:39:37 +0000 |
| commit | 41e0951d915ad5cf660ca227be2f4c844dcbdf8e (patch) | |
| tree | acfe48ed3b63e8ade74b262af7af7d4bec386b19 /lib | |
| parent | 1cb91c6a78f1b564b196ff69d339b75c56d1a6d4 (diff) | |
| download | samba-41e0951d915ad5cf660ca227be2f4c844dcbdf8e.tar.gz samba-41e0951d915ad5cf660ca227be2f4c844dcbdf8e.tar.bz2 samba-41e0951d915ad5cf660ca227be2f4c844dcbdf8e.zip | |
ldb: Don’t decrement reference count until object is no longer needed
If ‘tmp’ happens to be garbage-collected, ‘name’ will become invalid.
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/ldb/pyldb.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/ldb/pyldb.c b/lib/ldb/pyldb.c index 6215efb3d4d..8db6ccb8bc1 100644 --- a/lib/ldb/pyldb.c +++ b/lib/ldb/pyldb.c @@ -4363,10 +4363,10 @@ static PyObject *py_register_module(PyObject *module, PyObject *args) TALLOC_FREE(ops); return NULL; } - Py_XDECREF(tmp); Py_INCREF(input); ops->name = talloc_strdup(ops, name); + Py_XDECREF(tmp); ops->private_data = input; ops->init_context = py_module_init; ops->search = py_module_search; |