summaryrefslogtreecommitdiff
path: root/python
diff options
context:
space:
mode:
authorJennifer Sutton <jennifersutton@catalyst.net.nz>2025-08-12 12:26:52 +1200
committerDouglas Bagnall <dbagnall@samba.org>2025-08-27 03:41:36 +0000
commit32bfbc788d2fd161569f2ac3c192667a3cd196a9 (patch)
tree513be158cc6e614fe2d8bc9ad3d65f56c73d0be5 /python
parentc88164ee6887d21ddf5d1a272d31c1178e8cc23b (diff)
downloadsamba-32bfbc788d2fd161569f2ac3c192667a3cd196a9.tar.gz
samba-32bfbc788d2fd161569f2ac3c192667a3cd196a9.tar.bz2
samba-32bfbc788d2fd161569f2ac3c192667a3cd196a9.zip
python:samba: Raise an exception if we can’t parse a Markdown operation
Otherwise we would continue with the wrong GUID and filename. Signed-off-by: Jennifer Sutton <jennifersutton@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Diffstat (limited to 'python')
-rw-r--r--python/samba/ms_forest_updates_markdown.py9
1 files changed, 5 insertions, 4 deletions
diff --git a/python/samba/ms_forest_updates_markdown.py b/python/samba/ms_forest_updates_markdown.py
index 0a0d2111a72..12a2041459a 100644
--- a/python/samba/ms_forest_updates_markdown.py
+++ b/python/samba/ms_forest_updates_markdown.py
@@ -253,10 +253,11 @@ def read_ms_markdown(in_file, out_folder=None, out_dict=None):
if updates:
for update in updates[2:]:
output = re.match(r'Operation (\d+): {(.*)}', update[0])
- if output:
- # print output.group(1), output.group(2)
- guid = output.group(2)
- filename = "%s-{%s}.ldif" % (output.group(1).zfill(4), guid)
+ if not output:
+ raise Exception(update)
+
+ guid = output.group(2)
+ filename = "%s-{%s}.ldif" % (output.group(1).zfill(4), guid)
found = False