summaryrefslogtreecommitdiff
path: root/python
diff options
context:
space:
mode:
authorRob van der Linde <rob@catalyst.net.nz>2023-12-13 14:03:14 +1300
committerDouglas Bagnall <dbagnall@samba.org>2023-12-21 02:05:38 +0000
commitba29bb54cada2e0d01a8b6f7a7587696d44fa1f9 (patch)
tree565e45c3295540c4cab8e798c4669f7082e3cdb4 /python
parent5e823724389984379ae1f624cf1051a77179ef28 (diff)
downloadsamba-ba29bb54cada2e0d01a8b6f7a7587696d44fa1f9.tar.gz
samba-ba29bb54cada2e0d01a8b6f7a7587696d44fa1f9.tar.bz2
samba-ba29bb54cada2e0d01a8b6f7a7587696d44fa1f9.zip
selftest: require named parameters for callers of connect_samdb() and connect_samdb_ex()
Signed-off-by: Rob van der Linde <rob@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Diffstat (limited to 'python')
-rw-r--r--python/samba/tests/__init__.py9
1 files changed, 5 insertions, 4 deletions
diff --git a/python/samba/tests/__init__.py b/python/samba/tests/__init__.py
index a9f45b437c2..318d1956619 100644
--- a/python/samba/tests/__init__.py
+++ b/python/samba/tests/__init__.py
@@ -580,7 +580,7 @@ class BlackboxTestCase(TestCaseInTempDir):
return password
-def connect_samdb(samdb_url, lp=None, session_info=None, credentials=None,
+def connect_samdb(samdb_url, *, lp=None, session_info=None, credentials=None,
flags=0, ldb_options=None, ldap_only=False, global_schema=True):
"""Create SamDB instance and connects to samdb_url database.
@@ -625,7 +625,7 @@ def connect_samdb(samdb_url, lp=None, session_info=None, credentials=None,
global_schema=global_schema)
-def connect_samdb_ex(samdb_url, lp=None, session_info=None, credentials=None,
+def connect_samdb_ex(samdb_url, *, lp=None, session_info=None, credentials=None,
flags=0, ldb_options=None, ldap_only=False):
"""Connects to samdb_url database
@@ -637,8 +637,9 @@ def connect_samdb_ex(samdb_url, lp=None, session_info=None, credentials=None,
:param ldap_only: If set, only remote LDAP connection will be created.
:return: (sam_db_connection, rootDse_record) tuple
"""
- sam_db = connect_samdb(samdb_url, lp, session_info, credentials,
- flags, ldb_options, ldap_only)
+ sam_db = connect_samdb(samdb_url, lp=lp, session_info=session_info,
+ credentials=credentials, flags=flags,
+ ldb_options=ldb_options, ldap_only=ldap_only)
# fetch RootDse
res = sam_db.search(base="", expression="", scope=ldb.SCOPE_BASE,
attrs=["*"])