summaryrefslogtreecommitdiff
path: root/python
diff options
context:
space:
mode:
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>2022-06-22 15:21:31 +1200
committerAndreas Schneider <asn@cryptomilk.org>2022-08-26 08:59:28 +0000
commitfa3f0499cc1709fefaf95a6a6902651ba3961c8d (patch)
treeecb019cd58a1e08ae39b9b942c06fef9770e6f93 /python
parent4f902dba336f9d2aabb31e2ba6acf2b8ad726fcc (diff)
downloadsamba-fa3f0499cc1709fefaf95a6a6902651ba3961c8d.tar.gz
samba-fa3f0499cc1709fefaf95a6a6902651ba3961c8d.tar.bz2
samba-fa3f0499cc1709fefaf95a6a6902651ba3961c8d.zip
pyglue:generate_random_[machine]_password: ValueError for bad values
The actual range is 14 to 255 for machine passwords, and there is a min <= max check for both. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Fri Aug 26 08:59:28 UTC 2022 on sn-devel-184
Diffstat (limited to 'python')
-rw-r--r--python/pyglue.c10
1 files changed, 10 insertions, 0 deletions
diff --git a/python/pyglue.c b/python/pyglue.c
index dee3c296e03..60592874ae6 100644
--- a/python/pyglue.c
+++ b/python/pyglue.c
@@ -74,6 +74,11 @@ static PyObject *py_generate_random_password(PyObject *self, PyObject *args)
retstr = generate_random_password(NULL, min, max);
if (retstr == NULL) {
+ if (errno == EINVAL) {
+ PyErr_Format(PyExc_ValueError,
+ "invalid range: %d - %d",
+ min, max);
+ }
return NULL;
}
ret = PyUnicode_FromString(retstr);
@@ -104,6 +109,11 @@ static PyObject *py_generate_random_machine_password(PyObject *self, PyObject *a
retstr = generate_random_machine_password(NULL, min, max);
if (retstr == NULL) {
+ if (errno == EINVAL) {
+ PyErr_Format(PyExc_ValueError,
+ "invalid range: %d - %d",
+ min, max);
+ }
return NULL;
}
ret = PyUnicode_FromString(retstr);