summaryrefslogtreecommitdiff
path: root/source4
diff options
context:
space:
mode:
authorJoseph Sutton <josephsutton@catalyst.net.nz>2023-08-10 15:11:51 +1200
committerAndrew Bartlett <abartlet@samba.org>2023-08-14 04:57:34 +0000
commit09e13845aecb6b7e6e23a2ea4c8fccb8fe2a86f6 (patch)
tree95fe3de1631c2ee4fe9a0a59b130181ae028ab3b /source4
parent26e2e891d0cebd68555cf17df2e6bd9b819b606a (diff)
downloadsamba-09e13845aecb6b7e6e23a2ea4c8fccb8fe2a86f6.tar.gz
samba-09e13845aecb6b7e6e23a2ea4c8fccb8fe2a86f6.tar.bz2
samba-09e13845aecb6b7e6e23a2ea4c8fccb8fe2a86f6.zip
s4:kdc: Fix leak of sdb_entry
We should take the common ‘out’ path to ensure that we call sdb_entry_free() on the entry. Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Diffstat (limited to 'source4')
-rw-r--r--source4/kdc/db-glue.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/source4/kdc/db-glue.c b/source4/kdc/db-glue.c
index e6aadaf3539..37f9734fa91 100644
--- a/source4/kdc/db-glue.c
+++ b/source4/kdc/db-glue.c
@@ -1680,7 +1680,8 @@ static krb5_error_code samba_kdc_message2entry(krb5_context context,
kdc_db_ctx->msg_ctx,
kdc_db_ctx->ev_ctx,
msg->dn);
- return SDB_ERR_NOT_FOUND_HERE;
+ ret = SDB_ERR_NOT_FOUND_HERE;
+ goto out;
} else {
/*
* oh, no password. Apparently (comment in