diff options
| author | Joseph Sutton <josephsutton@catalyst.net.nz> | 2023-10-31 12:11:37 +1300 |
|---|---|---|
| committer | Andrew Bartlett <abartlet@samba.org> | 2023-11-02 03:08:37 +0000 |
| commit | fa25793ebff92bee2bb1bf0b437b5f705ee8a1dc (patch) | |
| tree | 18864378dbdc8e3c4c3030f214b53724b07a86b9 /source4 | |
| parent | c095ec02ff1a13bed5503a460eb6a8a39f03ade3 (diff) | |
| download | samba-fa25793ebff92bee2bb1bf0b437b5f705ee8a1dc.tar.gz samba-fa25793ebff92bee2bb1bf0b437b5f705ee8a1dc.tar.bz2 samba-fa25793ebff92bee2bb1bf0b437b5f705ee8a1dc.zip | |
s4:rpc_server: Properly initialize ‘lsa_CreateTrustedDomainEx2’ structure (CID 1499407)
dcesrv_lsa_CreateTrustedDomain_base() invokes DCESRV_PULL_HANDLE(),
which invokes DCESRV_PULL_HANDLE_RETVAL(), which invokes
DCESRV_CHECK_HANDLE(), which might invoke DCESRV_FAULT(), which accesses
r2.out.result, which is uninitialized — invoking undefined behaviour.
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Diffstat (limited to 'source4')
| -rw-r--r-- | source4/rpc_server/lsa/dcesrv_lsa.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/source4/rpc_server/lsa/dcesrv_lsa.c b/source4/rpc_server/lsa/dcesrv_lsa.c index 447789708f1..d1342747e88 100644 --- a/source4/rpc_server/lsa/dcesrv_lsa.c +++ b/source4/rpc_server/lsa/dcesrv_lsa.c @@ -1445,7 +1445,7 @@ static NTSTATUS dcesrv_lsa_CreateTrustedDomainEx(struct dcesrv_call_state *dce_c static NTSTATUS dcesrv_lsa_CreateTrustedDomain(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx, struct lsa_CreateTrustedDomain *r) { - struct lsa_CreateTrustedDomainEx2 r2; + struct lsa_CreateTrustedDomainEx2 r2 = {}; r2.in.policy_handle = r->in.policy_handle; r2.in.info = talloc(mem_ctx, struct lsa_TrustDomainInfoInfoEx); |