summaryrefslogtreecommitdiff
path: root/ctdb/tests/UNIT/shellcheck/scripts
AgeCommit message (Collapse)AuthorFilesLines
2022-07-22ctdb-scripts: Avoid ShellCheck warning SC2164Martin Schwenke1-4/+1
SC2164 (warning): Use 'cd ... || exit' or 'cd ... || return' in case cd fails. A problem can only occur if /etc/ctdb/ or an important subdirectory is removed, which means the script itself would not be found. Use && to silence ShellCheck. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
2020-07-22ctdb-tests: Drop unreachable lineMartin Schwenke1-1/+0
ctdb_test_skip() will exit. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
2020-07-22ctdb-tests: Redirect stderr too when checking for shellcheckMartin Schwenke1-1/+1
Avoid: .../UNIT/shellcheck/scripts/local.sh: line 14: type: shellcheck: not found The "type" command in dash prints the "not found" message to stdout but the bash version prints to stderr, so redirect stderr too. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
2020-07-22Revert "ctdb-tests: Redirect stderr too when checking for shellcheck"Martin Schwenke1-1/+1
Fix missing Reviewed-by: tag. This reverts commit 847aa0e367c721944650aa34d67f8073461ae272. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
2020-07-22Revert "ctdb-tests: Drop unreachable line"Martin Schwenke1-0/+1
Fix missing Reviewed-by: tag. This reverts commit a55dd6f17b6d65db77bcd4f5a011e9aef64729e5. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
2020-07-22ctdb-tests: Drop unreachable lineMartin Schwenke1-1/+0
ctdb_test_skip() will exit. Signed-off-by: Martin Schwenke <martin@meltin.net>
2020-07-22ctdb-tests: Redirect stderr too when checking for shellcheckMartin Schwenke1-1/+1
Avoid: .../UNIT/shellcheck/scripts/local.sh: line 14: type: shellcheck: not found The "type" command in dash prints the "not found" message to stdout but the bash version prints to stderr, so redirect stderr too. Signed-off-by: Martin Schwenke <martin@meltin.net>
2020-03-10ctdb-tests: Use ctdb_test_skip() when shellcheck is not installedMartin Schwenke1-1/+1
When the tests are run interactively this will make it more noticeable that shellcheck is not installed because the test summary will indicate missing tests. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
2019-09-26ctdb-tests: Move shellcheck tests to UNIT/ subdirectoryMartin Schwenke1-0/+37
Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>