summaryrefslogtreecommitdiff
path: root/lib/mscat
AgeCommit message (Collapse)AuthorFilesLines
2023-09-14lib:mscat: Remove unnecessary castsJoseph Sutton1-5/+5
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2023-08-08lib:mscat: Add missing newlines to logging messagesJoseph Sutton2-26/+26
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2023-06-30Remove rudundent check for gnutls_pkcs7_get_embedded_data_oid as we now ↵Andrew Bartlett1-2/+1
require GnuTLS 3.6.13 Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
2021-08-06lib;smbd: Fix the -Os build by initializing variablesVolker Lendecke1-2/+2
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2021-06-09lib:mscat: Don't use deprecated typesAndreas Schneider1-9/+9
Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Alexander Bokovoy <ab@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Wed Jun 9 16:54:23 UTC 2021 on sn-devel-184
2019-05-24lib:mscat: Add missing return check for error in dumpsmcatAndreas Schneider1-3/+12
Found by csbuild. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Gary Lockyer <gary@samba.org>
2019-04-30waf: Move gnutls_pkcs7_get_embedded_data_oid to main gnutls fileAndreas Schneider1-6/+0
Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2019-03-20build: Allow build when --disable-gnutls is setAndrew Bartlett1-1/+5
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13844 Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org> Autobuild-Date(master): Wed Mar 20 05:25:48 UTC 2019 on sn-devel-144
2019-03-08samba-o3: fix -Werror=maybe-uninitialized in lib/mscat/mscat_pks7.cJoe Guo1-1/+5
samba-o3 test failed in ubuntu:1804 image with: ../../lib/mscat/mscat_pkcs7.c: In function ‘mscat_pkcs7_import_catfile’: ../../lib/mscat/mscat_pkcs7.c:143:18: error: ‘blob.length’ may be used uninitialized in this function [-Werror=maybe-uninitialized] mscat_data.size = blob.length; ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~ ../../lib/mscat/mscat_pkcs7.c:142:18: error: ‘blob.data’ may be used uninitialized in this function [-Werror=maybe-uninitialized] mscat_data.data = blob.data; ~~~~~~~~~~~~~~~~^~~~~~~~~~~ ../../lib/mscat/mscat_pkcs7.c: In function ‘mscat_pkcs7_verify’: ../../lib/mscat/mscat_pkcs7.c:225:16: error: ‘blob.length’ may be used uninitialized in this function [-Werror=maybe-uninitialized] ca_data.size = blob.length; ~~~~~~~~~~~~~^~~~~~~~~~~~~ ../../lib/mscat/mscat_pkcs7.c:224:16: error: ‘blob.data’ may be used uninitialized in this function [-Werror=maybe-uninitialized] ca_data.data = blob.data; ~~~~~~~~~~~~~^~~~~~~~~~~ cc1: all warnings being treated as errors Since in `mscat_read_file`, it may still return rc = 0 while goto error, ends up with blob uninitialized. Signed-off-by: Joe Guo <joeg@catalyst.net.nz> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2019-01-19lib:mscat: Use size_t for len value to fix build issueAndreas Schneider1-3/+6
asn1_read_value_type() only uses it as an unsigned it, a negative value isn't assinged. Signed-off-by: Andreas Schneider <asn@samba.org>
2019-01-19lib:mscat: Fix may be used uninitialized warningsAndreas Schneider1-2/+6
Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
2018-09-05lib/mscat: fix logging in wscriptAlexander Bokovoy1-1/+1
2018-08-09lib: Add support to parse MS Catalog filesAndreas Schneider7-0/+1978
Signed-off-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Thu Aug 9 19:57:02 CEST 2018 on sn-devel-144