summaryrefslogtreecommitdiff
path: root/libcli/smbreadline
AgeCommit message (Collapse)AuthorFilesLines
2025-01-21lib:replace: Don't use deprecated readline CPPFunction castAndreas Schneider1-3/+5
HAVE_RL_COMPLETION_FUNC_T was unused and not checking for the right function. libcli/smbreadline/smbreadline.c: In function ‘smb_readline’: libcli/smbreadline/smbreadline.c:139:17: warning: ‘CPPFunction’ is deprecated [-Wdeprecated-declarations] 139 | rl_attempted_completion_function = RL_COMPLETION_CAST completion_fn; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ libcli/smbreadline/smbreadline.c:139:50: error: assignment to ‘char ** (*)(const char *, int, int)’ from incompatible pointer type ‘char ** (*)(void)’ [-Wincompatible-pointer-types] 139 | rl_attempted_completion_function = RL_COMPLETION_CAST completion_fn; | ^ BUG: https://bugzilla.samba.org/show_bug.cgi?id=15788 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Alexander Bokovoy <ab@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Tue Jan 21 19:38:37 UTC 2025 on atb-devel-224
2023-06-23libcli:smbreadline: Fix code spellingAndreas Schneider1-1/+1
Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2018-11-28libcli:smbreadline: Use #ifdef instead of #if for config.h definitionsAndreas Schneider1-4/+4
Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
2017-11-24lib/smbreadline: detect picky compile issue with readline.hUri Simchoni1-0/+33
readline.h has build issues with clang if -Wstrict-prototypes is enabled. Detect this and also detect whether the known workaround works. Fix suggested by Timur I. Bakeyev <timur@freebsd.org> cf. https://lists.gnu.org/archive/html/bug-readline/2014-04/msg00018.html cf. https://lists.samba.org/archive/samba-technical/2017-November/123923.html Signed-off-by: Uri Simchoni <uri@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2016-12-11lib: smbreadline xfile->stdioVolker Lendecke1-6/+5
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2016-11-20lib: Remove global xfile.h includesVolker Lendecke1-0/+1
This makes it more obvious where this legacy code is used Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Sun Nov 20 06:23:19 CET 2016 on sn-devel-144
2015-10-07Change the libreadline word-break character set to only space, TAB and NL so ↵Richard Sharpe1-0/+6
that we can attempt to do tab completion across backslashes. This turned out to be all that was needed to enable cd to handle multiple directory levels. Signed-off-by: Richard Sharpe <rsharpe@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Wed Oct 7 04:16:24 CEST 2015 on sn-devel-104
2014-03-13smbreadline: switch to new-style readline typedefGustavo Zacarias1-1/+1
Function, CPFunction, CPPFunction and VFunction typedefs are considered old-style (deprecated) starting from readline 4.2 (circa 2001). Compatibility typedefs have been in place up to readline 6.2 but were removed with the 6.3 release thus causing builds to break. Switch to the new-style specific prototyped typedef. Return value is unused so the callback should still be void (see readline/input.c around line 456 in version 6.3). Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Thu Mar 13 00:21:47 CET 2014 on sn-devel-104
2011-06-10libcli/smbreadline/smbreadline.h: fix licence/copyrightGünther Deschner1-0/+20
Guenther
2011-02-28libcli: Eliminate select from smb_readline_replacementVolker Lendecke1-7/+5
2010-10-31s4: Remove the old perl/m4/make/mk-based build system.Jelmer Vernooij1-96/+0
The new waf-based build system now has all the same functionality, and the old build system has been broken for quite some time. Autobuild-User: Jelmer Vernooij <jelmer@samba.org> Autobuild-Date: Sun Oct 31 02:01:44 UTC 2010 on sn-devel-104
2010-10-19readline: fixed the test for history_list()Andrew Tridgell1-1/+1
2010-10-01samba: share readline wrappers among all buildsystems.Günther Deschner5-0/+346
Guenther
generated by cgit v1.2.3 (git 2.25.1) at 2026-05-06 19:44:29 +0000