summaryrefslogtreecommitdiff
path: root/source3/lib/fstring.c
AgeCommit message (Collapse)AuthorFilesLines
2022-10-25s3-lib: restore truncating behavior of push_ascii_nstring()Philipp Gesang1-2/+5
Some users of push_ascii_nstring() (notably name_to_unstring()) expect the output to be truncated if it would exceed the size of an nstring after conversion. However this broke in 2011 due to commit d546adeab5 ("Change convert_string_internal() and convert_string_error() to bool return"). This patch restores the old behavior. The issue can be observed in syslog after setting the ``workgroup`` to a 16+ characters long string which triggers a DEBUG() message: Oct 17 11:28:45 dev nmbd[11716]: name_to_nstring: workgroup name 0123456789ABCDEF0123456789ABCDEF is too long. Truncating to Signed-off-by: Philipp Gesang <philipp.gesang@intra2net.com> Reviewed-by: Noel Power <npower@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Noel Power <npower@samba.org> Autobuild-Date(master): Tue Oct 25 16:25:40 UTC 2022 on sn-devel-184
2011-04-13s3-lib Remove more unused fstring.c functionsAndrew Bartlett1-46/+0
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-04-13s3-lib: Remove unused pull_ucs2_fstring()Andrew Bartlett1-4/+0
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-03-30Fix convert_string() to take a *converted_size arg. and return a bool.Jeremy Allison1-3/+4
Makes these interfaces much harder to misuse and easier to ensure error checking. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Wed Mar 30 23:59:37 CEST 2011 on sn-devel-104
2011-03-30Change convert_string_internal() and convert_string_error() to bool return.Jeremy Allison1-6/+8
Move closer to makeing all convert_string_XXX functions return bool. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Wed Mar 30 20:58:10 CEST 2011 on sn-devel-104
2011-03-30Fix the nstring calls to use the correct sizes.Jeremy Allison1-6/+6
2011-03-25s3-string: removed last use of conv_silentAndrew Tridgell1-31/+11
This replaces the push_ascii_nstring() implementation with a call to convert_string_error() Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-03-25s3-string: moved fstring functions into their own fileAndrew Tridgell1-0/+131
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
generated by cgit v1.2.3 (git 2.25.1) at 2026-05-07 02:16:36 +0000