summaryrefslogtreecommitdiff
path: root/source3/lib/netapi/user.c
AgeCommit message (Collapse)AuthorFilesLines
2024-09-26s3:lib/netapi: make use of dcerpc_binding_handle_transport_session_key()Stefan Metzmacher1-2/+4
Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
2021-08-06libnetapi: Save lines with any_nt_status_not_ok()Volker Lendecke1-165/+33
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-09-26s3/lib/netapi: clang: Fix 'Value stored during initialization is never read'Noel Power1-5/+5
Fixes: source3/lib/netapi/user.c:1290:11: warning: Value stored to 'status' during its initialization is never read <--[clang] NTSTATUS status = NT_STATUS_OK; ^~~~~~ ~~~~~~~~~~~~ source3/lib/netapi/user.c:1610:11: warning: Value stored to 'status' during its initialization is never read <--[clang] NTSTATUS status = NT_STATUS_OK; ^~~~~~ ~~~~~~~~~~~~ source3/lib/netapi/user.c:2990:11: warning: Value stored to 'status' during its initialization is never read <--[clang] NTSTATUS status = NT_STATUS_OK; ^~~~~~ ~~~~~~~~~~~~ source3/lib/netapi/user.c:3184:11: warning: Value stored to 'status' during its initialization is never read <--[clang] NTSTATUS status = NT_STATUS_OK; ^~~~~~ ~~~~~~~~~~~~ source3/lib/netapi/user.c:3522:11: warning: Value stored to 'status' during its initialization is never read <--[clang] NTSTATUS status = NT_STATUS_OK; ^~~~~~ ~~~~~~~~~~~~ Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Jeremy Allison <jra@samba.org>
2019-07-26s3:lib: Use the passed mem_ctx instead of talloc_tos()Andreas Schneider1-4/+4
Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2019-07-26s3:rpc_client: Return NTSTATUS for init_samr_CryptPasswordEx()Andreas Schneider1-3/+6
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2019-07-26s3:rpc_client: Return NTSTATUS for init_samr_CryptPassword()Andreas Schneider1-3/+6
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2016-09-28werror: replace WERR_UNKNOWN_LEVEL with WERR_INVALID_LEVEL in ↵Günther Deschner1-10/+10
source3/lib/netapi/ Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2016-09-28werror: replace WERR_INVALID_PARAM with WERR_INVALID_PARAMETER in ↵Günther Deschner1-10/+10
source3/lib/netapi/ Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2016-09-28werror: replace WERR_GENERAL_FAILURE with WERR_GEN_FAILURE in ↵Günther Deschner1-2/+2
source3/lib/netapi/ Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2016-09-28werror: replace WERR_NOMEM with WERR_NOT_ENOUGH_MEMORY in source3/lib/netapi/Günther Deschner1-12/+12
Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2015-03-26libnetapi: Fix 241166 Fixing logically dead codeAnoop C S1-3/+0
Signed-off-by: Anoop C S <achiraya@redhat.com> Reviewed-by: Guenther Deschner <gd@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Thu Mar 26 17:30:27 CET 2015 on sn-devel-104
2014-11-03Change expired password flag indicatorGabriel Buades1-1/+1
Signed-off-by: Gabriel Buades <gbuades@soffid.com> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Jim McDonough <jmcd@samba.org>
2013-12-09CVE-2013-4408:s3:Ensure LookupRids() replies arrays are range checked.Jeremy Allison1-0/+16
Bug: https://bugzilla.samba.org/show_bug.cgi?id=10185 Signed-off-by: Jeremy Allison <jra@samba.org> Signed-off-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Karolin Seeger <kseeger@samba.org> Autobuild-Date(master): Mon Dec 9 09:00:41 CET 2013 on sn-devel-104
2013-12-09CVE-2013-4408:s3:Ensure LookupNames replies arrays are range checked.Jeremy Allison1-0/+56
Bug: https://bugzilla.samba.org/show_bug.cgi?id=10185 Signed-off-by: Stefan Metzmacher <metze@samba.org> Signed-off-by: Jeremy Allison <jra@samba.org>
2013-08-05s3-libnetapi: pass down ndr_interface_table to libnetapi_open_pipe().Günther Deschner1-11/+11
Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
2012-12-21s3-netapi: Add missing break in NetUserSetInfo_r().Andreas Schneider1-0/+1
Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
2012-12-12s3-netapi: Initialize group_handle of NetUserSetGroups_r.Andreas Schneider1-0/+1
Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
2011-06-09s3-talloc Change TALLOC_ZERO_ARRAY() to talloc_zero_array()Andrew Bartlett1-3/+3
Using the standard macro makes it easier to move code into common, as TALLOC_ZERO_ARRAY isn't standard talloc.
2011-06-09s3-talloc Change TALLOC_ARRAY() to talloc_array()Andrew Bartlett1-1/+1
Using the standard macro makes it easier to move code into common, as TALLOC_ARRAY isn't standard talloc.
2011-05-30s3: fix some -Wunused-but-set-variable build warnings.Günther Deschner1-2/+0
Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Mon May 30 17:41:18 CEST 2011 on sn-devel-104
2011-05-05More const fixes for compiler warnings from the waf build.Jeremy Allison1-1/+1
2011-04-24s3:rpc_client: map fault codes to NTSTATUS with dcerpc_fault_to_nt_status()Stefan Metzmacher1-1/+1
Most fault codes have a NTSTATUS representation, so use that. This brings the fault handling in common with the source4/librpc/rpc code, which make it possible to share more highlevel code, between source3 and source4 as the error checking can be the same now. metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Sun Apr 24 10:44:53 CEST 2011 on sn-devel-104
2011-03-25s3-netapi: fix memoryleak while not using talloc_tos() in ↵Günther Deschner1-2/+2
cli_get_session_key() usage. Thanks Volker! Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Fri Mar 25 18:21:18 CET 2011 on sn-devel-104
2011-03-24s3-netapi: use cli_get_session_key() in netapi.Günther Deschner1-2/+17
Guenther
2011-03-02s3-libds: use already existing ../libds/common/flag_mapping.h header.Günther Deschner1-0/+1
Guenther
2011-02-01s3-libnetapi: prefer dcerpc_samr_X functions in lib/netapi/user.c.Günther Deschner1-130/+377
Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Tue Feb 1 13:41:42 CET 2011 on sn-devel-104
2010-12-30s3:lib/netapi: don't set SAMR_FIELD_FULL_NAME if we just want to set the ↵Stefan Metzmacher1-3/+0
account name (bug #7896) metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Thu Dec 30 18:09:13 CET 2010 on sn-devel-104
2010-10-12libcli/security Provide a common, top level libcli/security/security.hAndrew Bartlett1-1/+1
This will reduce the noise from merges of the rest of the libcli/security code, without this commit changing what code is actually used. This includes (along with other security headers) dom_sid.h and security_token.h Andrew Bartlett Autobuild-User: Andrew Bartlett <abartlet@samba.org> Autobuild-Date: Tue Oct 12 05:54:10 UTC 2010 on sn-devel-104
2010-10-02s3: Attempt to fix bug 7665Volker Lendecke1-40/+40
Quite a few of our internal routines put stuff on talloc_tos() these days. In top-level netapi routines, properly allocate a stackframe and clean it again. Also, don't leak memory in the rpccli_ callers onto the libnetapi context.
2010-09-20s3-util: use shared dom_sid_dup.Günther Deschner1-7/+8
Guenther
2010-08-25s3-lsa: separate out init_lsa headers.Günther Deschner1-0/+1
Guenther
2010-07-05samr.idl:UserInfo structures - fix some names according to MS-SAMR documentationMatthias Dieter Wallnöfer1-2/+2
See MS-SAMR section "FULL IDL"
2010-07-01s3-libads: only include libds flags where needed.Günther Deschner1-0/+1
Guenther
2010-06-03s3-security: use shared "Standard access rights.".Günther Deschner1-2/+2
Guenther
2010-05-21s3:dom_sid Global replace of DOM_SID with struct dom_sidAndrew Bartlett1-1/+1
This matches the structure that new code is being written to, and removes one more of the old-style named structures, and the need to know that is is just an alias for struct dom_sid. Andrew Bartlett Signed-off-by: Günther Deschner <gd@samba.org>
2010-05-18s3-rpc_client: move protos to init_samr.hGünther Deschner1-0/+1
Guenther
2009-11-26s3-rpc: Avoid including every pipe's client and server stubs everywhere in ↵Günther Deschner1-0/+1
samba. Guenther
2009-11-08Revert "s3: Make libnetapi_open_pipe take strings instead of a ↵Volker Lendecke1-11/+11
ndr_interface_table" This reverts commit 5fc9d93408effe75abcd231c45cbc14656692ebe.
2009-11-08s3: Make libnetapi_open_pipe take strings instead of a ndr_interface_tableVolker Lendecke1-11/+11
2009-09-16s3-netapi: Fix Coverity #668: FORWARD_NULL.Günther Deschner1-1/+1
Guenther
2009-09-16s3-netapi: Fix Coverity #669 FORWARD_NULL.Günther Deschner1-1/+1
Guenthe
2009-09-16s3-netapi: Fix Coverity #670: FORWARD_NULL.Günther Deschner1-1/+1
Guenther
2009-07-13libds: merge the UF<->ACB flag mapping functions.Günther Deschner1-1/+1
Guenther
2009-06-26Fix some dead code warnings from SUN StudioVolker Lendecke1-2/+2
2009-06-16s3-netapi: Fix Bug #6451: net/libnetapi user rename using wrong access bits.Günther Deschner1-0/+2
Guenther
2009-04-15Fix bug #6089 - Winbind samr_OpenDomain not possible with Samba 3.2.6+Jeremy Allison1-15/+15
What a difference a name makes... :-). Just because something is missnamed SAMR_ACCESS_OPEN_DOMAIN, when it should actually be SAMR_ACCESS_LOOKUP_DOMAIN, don't automatically use it for a security check in _samr_OpenDomain(). Jeremy.
2009-03-26s3-net: Fix Bug #6102. NetQueryDisplayInformation could return wrong ↵Günther Deschner1-6/+12
information. Guenther
2009-03-20s3-netapi: Fix Coverity #774 (REVERSE_INULL).Günther Deschner1-6/+3
Guenther
2009-03-20s3-netapi: Fix Coverity #775 (REVERSE_INULL).Günther Deschner1-6/+3
Guenther
2009-03-18s3: remove POLICY_HND.Günther Deschner1-2/+2
Guenther