summaryrefslogtreecommitdiff
path: root/source3/passdb
AgeCommit message (Collapse)AuthorFilesLines
2026-02-20s3/passdb: add parameter to control handling of wellknown SIDs in pdb_tdbRalph Boehme1-0/+9
With "tdbsam:map wellknown", one can control if pdb_tdb should be used to map entries of wellknown SIDs or not. By default, they will not be mapped, as in previous releases. This is similar to commit 6a048b424a2ecf38614aa6912f0d8c8a26c87ad5 which added the option "tdbsam:map builtin" for the builtin groups. Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Fri Feb 20 15:20:31 UTC 2026 on atb-devel-224
2025-12-08auth: Use new data_blob_..._s() functions and remove talloc_keep_secret()Pavel Filipenský1-6/+3
Signed-off-by: Pavel Filipenský <pfilipensky@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
2025-11-10s3: talloc_destroy() -> TALLOC_FREE()Volker Lendecke1-2/+1
Sweeping change, I know. Should not change compiled code in most cases, the compiler should be smart enough to elide the assignment right before a return. In the cases where this is not right before the return, TALLOC_FREE() is safer as it makes use-after-free crash. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Anoop C S <anoopcs@samba.org>
2025-10-22s3:passdb: Fix memory leak in pdb_default_del_groupmem()Andreas Schneider1-3/+10
Indirect leak of 496 byte(s) in 1 object(s) allocated from: #0 0x7f1e45121c2b in malloc (/lib64/libasan.so.8+0x121c2b) (BuildId: 388ee9ac193f74c177c6f52988d2d0dab110de41) #1 0x7f1e44b586a0 in __talloc_with_prefix ../../lib/talloc/talloc.c:783 #2 0x7f1e44b59f75 in __talloc ../../lib/talloc/talloc.c:825 #3 0x7f1e44b59f75 in _talloc_named_const ../../lib/talloc/talloc.c:982 #4 0x7f1e44b59f75 in _talloc_zero ../../lib/talloc/talloc.c:2421 #5 0x7f1e42a18460 in samu_new ../../source3/passdb/passdb.c:63 #6 0x7f1e42a381ef in pdb_default_del_groupmem ../../source3/passdb/pdb_interface.c:1098 #7 0x7f1e42a364b1 in pdb_del_groupmem ../../source3/passdb/pdb_interface.c:1130 #8 0x000000388a57 in net_sam_delmem ../../source3/utils/net_sam.c:1324 #9 0x00000038ff79 in net_run_function ../../source3/utils/net_util.c:451 #10 0x00000038bfb6 in net_sam ../../source3/utils/net_sam.c:2306 #11 0x00000038ff79 in net_run_function ../../source3/utils/net_util.c:451 #12 0x0000002ea182 in main ../../source3/utils/net.c:1474 #13 0x7f1e3fc2b2fa in __libc_start_call_main (/lib64/libc.so.6+0x2b2fa) (BuildId: 8523b213e7586a93ab00f6dd476418b1e521e62c) #14 0x7ffe6b22b79f ([stack]+0x2079f) Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Anoop C S <anoopcs@samba.org> Autobuild-User(master): Anoop C S <anoopcs@samba.org> Autobuild-Date(master): Wed Oct 22 15:21:22 UTC 2025 on atb-devel-224
2025-10-22s3:passdb: Fix memory leak in pdb_default_add_groupmem()Andreas Schneider1-3/+10
Indirect leak of 496 byte(s) in 1 object(s) allocated from: #0 0x7f068f921c2b in malloc (/lib64/libasan.so.8+0x121c2b) (BuildId: 388ee9ac193f74c177c6f52988d2d0dab110de41) #1 0x7f068f4266a0 in __talloc_with_prefix ../../lib/talloc/talloc.c:783 #2 0x7f068f427f75 in __talloc ../../lib/talloc/talloc.c:825 #3 0x7f068f427f75 in _talloc_named_const ../../lib/talloc/talloc.c:982 #4 0x7f068f427f75 in _talloc_zero ../../lib/talloc/talloc.c:2421 #5 0x7f068cbba260 in samu_new ../../source3/passdb/passdb.c:63 #6 0x7f068cbda444 in pdb_default_add_groupmem ../../source3/passdb/pdb_interface.c:1022 #7 0x7f068cbd825d in pdb_add_groupmem ../../source3/passdb/pdb_interface.c:1054 #8 0x000000389322 in net_sam_addmem ../../source3/utils/net_sam.c:1255 #9 0x00000038ff79 in net_run_function ../../source3/utils/net_util.c:451 #10 0x00000038bfb6 in net_sam ../../source3/utils/net_sam.c:2306 #11 0x00000038ff79 in net_run_function ../../source3/utils/net_util.c:451 #12 0x0000002ea182 in main ../../source3/utils/net.c:1474 #13 0x7f068a42b2fa in __libc_start_call_main (/lib64/libc.so.6+0x2b2fa) (BuildId: 8523b213e7586a93ab00f6dd476418b1e521e62c) #14 0x7ffe0a90b7a1 ([stack]+0x207a1) Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Anoop C S <anoopcs@samba.org>
2025-09-24passdb: Fixing CID 1509029 for time_t in DEBUG statementRabinarayan Panigrahi1-6/+6
In the most likely scenario of time_t being 64 bit signed, we do the typecast to intmax_t to also log negative values correctly. Signed-off-by: Rabinarayan Panigrahi <rapanigr@redhat.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Anoop C S <anoopcs@samba.org> Reviewed-by: Vinit Agnihotri <vagnihot@redhat.com> Autobuild-User(master): Anoop C S <anoopcs@samba.org> Autobuild-Date(master): Wed Sep 24 06:44:50 UTC 2025 on atb-devel-224
2025-09-10source3/passdb: Follow up to the fix for CID 1508970Anoop C S1-2/+2
Fixing another occurrence for the same CID in the same DEBUG statement. See the previous commit c25a5a26a1cba698420fb64e23bee3b52540b21b. Signed-off-by: Anoop C S <anoopcs@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Anoop C S <anoopcs@samba.org> Autobuild-Date(master): Wed Sep 10 15:23:08 UTC 2025 on atb-devel-224
2025-09-10passdb: Fixing CID 1508971 for time_t in DEBUG statementRabinarayan Panigrahi1-4/+4
Fix: typecast changing from (unsigned int)badtime to (intmax_t)badtime as intmax_t can hold epoch seconds after 2038 year Signed-off-by: Rabinarayan Panigrahi <rapanigr@redhat.com> Reviewed-by: Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Andreas Schneider <asn@samba.org>
2025-09-10passdb: Fixing CID 1508970 for time_t in DEBUG statementRabinarayan Panigrahi1-2/+2
Fix: typecast changing from (unsigned int)entry->bad_password_time to (intmax_t)entry->bad_password_time as intmax_t can hold epoch seconds after 2038 year Signed-off-by: Rabinarayan Panigrahi <rapanigr@redhat.com> Reviewed-by: Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Andreas Schneider <asn@samba.org>
2025-09-05s3:net: Pass down the server from cmdline to sync_pw2keytabs()Andreas Schneider1-4/+6
This makes sure that during 'net ads join' the keytab create code - sync_pw2keytabs() talks to the same DC at what the machine account was created. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15905 Signed-off-by: Andreas Schneider <asn@samba.org> Signed-off-by: Pavel Filipenský <pfilipensky@samba.org> Pair-Programmed-With: Pavel Filipenský <pfilipensky@samba.org> Reviewed-by: Alexander Bokovoy <ab@samba.org> Autobuild-User(master): Pavel Filipensky <pfilipensky@samba.org> Autobuild-Date(master): Fri Sep 5 13:38:33 UTC 2025 on atb-devel-224
2025-08-27CID 1509059 winbind: Fixing print statement for time_tRabinarayan Panigrahi1-2/+2
Fixing DEBUG output for time_t to uintmax_t Signed-off-by: Rabinarayan Panigrahi <rapanigr@redhat.com> Reviewed-by: Volker Lendecke <vl@samba.org> Reviewed-by: Martin Schwenke <martin@meltin.net> Autobuild-User(master): Martin Schwenke <martins@samba.org> Autobuild-Date(master): Wed Aug 27 02:17:29 UTC 2025 on atb-devel-224
2025-08-18pdb_ldap: Fix memory leak CID#1363095Vinit Agnihotri1-0/+1
Signed-off-by: Vinit Agnihotri <vagnihot@redhat.com> Reviewed-by: Guenther Deschner <gd@samba.org> Reviewed-by: Anoop C S <anoopcs@samba.org> Autobuild-User(master): Anoop C S <anoopcs@samba.org> Autobuild-Date(master): Mon Aug 18 12:03:30 UTC 2025 on atb-devel-224
2025-08-07s3:passdb: Fix CIDs 1596750,1596751 uninitialized pointer readMichael Adam1-2/+2
This fixes two coverity issues of type CID 1596750 - uninitialized pointer read CID 1596751 - uninitialized pointer read It fixes one occurrence in each of pdb_samba_dsdb_create_user and pdb_samba_dsdb_create_alias Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Alexander Bokovoy <ab@samba.org> Reviewed-by: Rabinarayan Panigrahi <rapanigr@redhat.com> Reviewed-by: Shachar Sharon <ssharon@redhat.com> Autobuild-User(master): Anoop C S <anoopcs@samba.org> Autobuild-Date(master): Thu Aug 7 11:20:25 UTC 2025 on atb-devel-224
2025-03-29s3: Fix use of dbwrap_transaction_cancel() in machine_account_secrets.cPavel Filipenský1-2/+1
Signed-off-by: Pavel Filipenský <pfilipensky@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> Autobuild-User(master): Ralph Böhme <slow@samba.org> Autobuild-Date(master): Sat Mar 29 19:02:35 UTC 2025 on atb-devel-224
2025-02-22s3:passdb: add pdb_filter_hints()Stefan Metzmacher3-0/+443
This reveals information about our own domain/forest. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
2025-02-04s3,s4: Make case spelling of sAMAccountName consistentPavel Filipenský1-10/+10
Signed-off-by: Pavel Filipenský <pfilipensky@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
2024-12-02passdb: Fix Coverity ID 1509016 Use of 32-bit time_tVolker Lendecke1-2/+5
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Martin Schwenke <martin@meltin.net>
2024-12-02pdb_ldap: Fix Coverity ID 1508985 Use of 32-bit time_tVolker Lendecke1-2/+2
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Martin Schwenke <martin@meltin.net>
2024-09-30s3:passdb: ENCTYPE_DES_CBC_MD5 is not longer used in ↵Stefan Metzmacher1-3/+3
secrets_domain_info_kerberos_keys() Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Mon Sep 30 17:03:55 UTC 2024 on atb-devel-224
2024-09-20passdb: Simplify pdb_gethexhours() with hex_byte()Volker Lendecke1-16/+3
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Noel Power <noel.power@suse.com>
2024-08-27libsmb: Simplify pdb_sethexpwd with hex_byte()Volker Lendecke1-15/+3
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jennifer Sutton <jsutton@samba.org>
2024-07-26s3: Sync machine account password in secrets_{prepare,finish}_password_changePavel Filipenský1-2/+37
BUG: https://bugzilla.samba.org/show_bug.cgi?id=6750 Signed-off-by: Pavel Filipenský <pfilipensky@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
2024-07-26s3/passdb: add lookup_name_smbconf_ex() using lookup_name_internal()Ralph Boehme3-29/+389
Returns NTSTATUS instead of bool. lookup_name_smbconf() becomes a thin wrapper around lookup_name_smbconf_ex(). Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
2024-07-26s3/passdb: factor out lookup_name_internal()Ralph Boehme1-40/+81
lookup_name() becomes a thin wrapper around lookup_name_internal(). Prepares for adding more callers to lookup_name_internal() that are interested in the NTSTATUS return value to distinguish between NAME_NOT_FOUND lookup results and real errors. Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
2024-07-26s3/passdb: use winbind_lookup_name_ex() in lookup_name() instead of ↵Ralph Boehme1-26/+46
winbind_lookup_name() No change in behaviour, prepares for returning NTSTATUS instead of bool from lookup_name(). Review-with: git show -w Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
2024-07-17s3:passdb: don't clear the LM HASH without a password changeStefan Metzmacher1-1/+1
Updating things like the bad pwd count should not clear the stored LM HASH with 'lanman auth = no'. This allows testing with 'lanman auth = no' and 'lanman auth = yes'. BUG: https://bugzilla.samba.org/show_bug.cgi?id=9705 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
2024-04-30passdb: Use getline(3) to read our old machine sidVolker Lendecke1-11/+15
Don't read the whole file. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2024-04-21s4:dsdb: Make use of DSDB_SEARCH_UPDATE_MANAGED_PASSWORDS search flagJo Sutton1-1/+6
Signed-off-by: Jo Sutton <josutton@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2024-04-16lib: Give lib/util/util_file.c its own header fileVolker Lendecke1-0/+1
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Martin Schwenke <mschwenke@ddn.com>
2024-04-05s3:passdb: use DBG_ERR() for 'talloc_strdup failed' messagesStefan Metzmacher2-3/+3
Otherwise it's completely unclear where the messages come from Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2024-02-16s3:passdb: Reformat long lineJo Sutton1-1/+9
Signed-off-by: Jo Sutton <josutton@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2024-02-16s3:passdb: Reformat array of stringsJo Sutton1-9/+27
Signed-off-by: Jo Sutton <josutton@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2024-02-16s3:passdb: Make array of strings staticJo Sutton1-1/+1
Signed-off-by: Jo Sutton <josutton@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2024-02-16s3:passdb: Remove trailing whitespaceJo Sutton1-4/+4
Signed-off-by: Jo Sutton <josutton@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2024-01-23s3:passdb: Fix memory leak caused by recursion of get_global_sam_sid()Andreas Schneider1-4/+6
Direct leak of 68 byte(s) in 1 object(s) allocated from: #0 0x7f4f39cdc03f in malloc (/lib64/libasan.so.8+0xdc03f) (BuildId: 3e1694ad218c99a8b1b69231666a27df63cf19d0) #1 0x7f4f36fbe427 in malloc_ ../../source3/lib/util_malloc.c:38 #2 0x7f4f394b5e19 in pdb_generate_sam_sid ../../source3/passdb/machine_sid.c:90 #3 0x7f4f394b5e19 in get_global_sam_sid ../../source3/passdb/machine_sid.c:211 #4 0x7f4f394af366 in secrets_store_domain_sid ../../source3/passdb/machine_account_secrets.c:143 #5 0x7f4f394b5eb5 in pdb_generate_sam_sid ../../source3/passdb/machine_sid.c:110 #6 0x7f4f394b5eb5 in get_global_sam_sid ../../source3/passdb/machine_sid.c:211 #7 0x7f4f394af366 in secrets_store_domain_sid ../../source3/passdb/machine_account_secrets.c:143 #8 0x557a1f11d62c in net_setlocalsid ../../source3/utils/net.c:416 #9 0x557a1f1c9972 in net_run_function ../../source3/utils/net_util.c:464 #10 0x557a1f121129 in main ../../source3/utils/net.c:1372 #11 0x7f4f34c281af in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Tue Jan 23 14:30:58 UTC 2024 on atb-devel-224
2024-01-23s3:passdb: Do not leak memory in pdb_tdbAndreas Schneider1-0/+3
==19938==ERROR: LeakSanitizer: detected memory leaks Direct leak of 77 byte(s) in 1 object(s) allocated from: #0 0x7f7d482841f8 in strdup (/lib64/libasan.so.8+0x841f8) (BuildId: 3e1694ad218c99a8b1b69231666a27df63cf19d0) #1 0x7f7d47204846 (bin/shared/libsamba-util.so.0+0x4c846) (BuildId: 43b084eb9013442ac68eb1fc17649f142cbb0f94) #2 0x7f7d40b1d97a in pdb_init_tdbsam ../../source3/passdb/pdb_tdb.c:1361 #3 0x7f7d4715f266 (bin/shared/libsamba-passdb.so.0+0x76266) (BuildId: 13d2858e2217592a22a4ee9203fef759d52df733) #4 0x7f7d4715f57a (bin/shared/libsamba-passdb.so.0+0x7657a) (BuildId: 13d2858e2217592a22a4ee9203fef759d52df733) #5 0x7f7d47163700 (bin/shared/libsamba-passdb.so.0+0x7a700) (BuildId: 13d2858e2217592a22a4ee9203fef759d52df733) #6 0x55a9177d3853 in main ../../source3/smbd/server.c:1928 #7 0x7f7d434281af in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
2024-01-18s3:passdb: smbpasswd reset permissions only if not 0600Jones Syue1-8/+28
Browsing files or download files from samba server, smbd would check user's id to decide whether this user could access these files, by lookup user's information from the password file (e.g. /usr/local/samba/private/smbpasswd). smbd might goes through startsmbfilepwent(), this api calls [f]chmod() to make sure the password file has valid permissions 0600. Consider a scenario: we are doing a read performance benchmark about downloading a bunch of files (e.g. a thousand files) from a samba server, monitoring file system i/o activities counters, and expecting that should be only read operations on file system because this is just downloading, no uploading is involved. But actually found that still write operations on file system, because smbd lookup user and always reset 0600 permissions on password file while access each file, it makes dirty pages (inode modification) in ram, later triggered a kernel journal daemon to sync dirty pages into back storage (e.g. ext3 kjournald, or ext4 jbd2). This looks like not friendly for read performance benchmark if it happened on an entry-level systems with much less memory and limited computation power, because dirty pages syncing in the meantime slows down read performance. This patch adds fstat() before [f]chmod(), it would check whether password file has valid permissions 0600 or not. If 0600 smbd would bypass [f]chmod() to avoid making dirty pages on file systems. If not 0600 smbd would warn and go through [f]chmod() to set valid permissions 0600 to password file as earlier days. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15555 Signed-off-by: Jones Syue <jonessyue@qnap.com> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Thu Jan 18 10:28:19 UTC 2024 on atb-devel-224
2023-11-20Use python.h from libreplaceAndreas Schneider1-1/+1
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15513 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2023-10-27s3:passdb: Do not leak memory if memcache add failsAndreas Schneider1-3/+7
Indirect leak of 496 byte(s) in 1 object(s) allocated from: #0 0x7ffb062dc03f in malloc (/lib64/libasan.so.8+0xdc03f) (BuildId: 3e1694ad218c99a8b1b69231666a27df63cf19d0) #1 0x7ffb06025b3e in __talloc_with_prefix ../../lib/talloc/talloc.c:783 #2 0x7ffb06027512 in __talloc ../../lib/talloc/talloc.c:825 #3 0x7ffb06027512 in _talloc_named_const ../../lib/talloc/talloc.c:982 #4 0x7ffb06027512 in _talloc_zero ../../lib/talloc/talloc.c:2421 #5 0x7ffb05a0332c in samu_new ../../source3/passdb/passdb.c:63 #6 0x7ffb05a2031f in pdb_getsampwnam ../../source3/passdb/pdb_interface.c:351 #7 0x7ffb05a0540b in local_password_change ../../source3/passdb/passdb.c:752 #8 0x56291ddd4b8b in password_change ../../source3/utils/smbpasswd.c:273 #9 0x56291ddd5b59 in process_root ../../source3/utils/smbpasswd.c:478 #10 0x56291ddd5b59 in main ../../source3/utils/smbpasswd.c:661 #11 0x7ffb024281af in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2023-10-25s3:passdb: Fix code spellingJoseph Sutton2-6/+6
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2023-10-25s3:passdb: Fix code formattingJoseph Sutton1-1/+2
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2023-10-10pdb: Slightly simplify pdb_samba_dsdb_set_trusteddom_pw()Volker Lendecke1-6/+1
This is easier to read to me. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2023-09-27s3:passdb: Initialize ‘tm’ structureJoseph Sutton1-1/+1
‘tm’ must be initialized prior to calling strptime(). Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2023-08-14passdb: Fix a DBG statementVolker Lendecke1-1/+1
This is not pdb_getsampwent() Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2023-08-14passdb: Fix whitespaceVolker Lendecke3-84/+84
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2023-08-14passdb: Fix a DBG messageVolker Lendecke1-1/+2
This is not dsdb_add_domain_alias() Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2023-08-08s3:passdb: Fix typoJoseph Sutton1-1/+1
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2023-08-08s3:passdb: Add missing newlines to logging messagesJoseph Sutton5-20/+20
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2023-07-31dsdb: Use samdb_system_container_dn() in pdb_samba_dsdb_*()Andrew Bartlett1-4/+8
This makes more calls to add children, but avoids the cn=system string in the codebase which makes it easier to audit that this is always being built correctly. Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Mon Jul 31 07:20:21 UTC 2023 on atb-devel-224
2023-07-19s3:passdb: Fix code spellingAndreas Schneider9-15/+15
Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Joseph Sutton <josephsutton@catalyst.net.nz>
generated by cgit v1.2.3 (git 2.25.1) at 2026-05-06 18:15:15 +0000