summaryrefslogtreecommitdiff
path: root/source4/client
AgeCommit message (Collapse)AuthorFilesLines
2026-02-15lib: Move conv_str_bool() to its only userVolker Lendecke1-0/+25
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Anoop C S <anoopcs@samba.org>
2026-02-15lib: Remove very little used wrapper conv_str_u64()Volker Lendecke1-5/+10
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Anoop C S <anoopcs@samba.org>
2026-01-15s4:client:http_test fix Non-boolean returnedGary Lockyer1-1/+1
fix cppcheck source4/client/http_test.c:85:3: style: Non-boolean value returned from function returning bool [returnNonBoolInBooleanFunction] BUG: https://bugzilla.samba.org/show_bug.cgi?id=15924 Signed-off-by: Gary Lockyer <gary@catalyst.net.nz> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Anoop C S <anoopcs@samba.org>
2025-10-16tests: Run `dd` without any preloaded librariesAndreas Schneider1-1/+1
If AddressSanitizer is loaded it will detect alignment issues. The tool is not ours, so ignore it. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Anoop C S <anoopcs@samba.org> Autobuild-User(master): Anoop C S <anoopcs@samba.org> Autobuild-Date(master): Thu Oct 16 09:34:58 UTC 2025 on atb-devel-224
2025-04-18s4:libcli: pass struct loadparm_context to smbcli_full_connection()Stefan Metzmacher2-2/+5
Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
2025-04-18s4:libcli: pass struct loadparm_context to smbcli_socket_connect()Stefan Metzmacher1-1/+3
Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
2025-04-18s4:client: remove unused ports from do_connect()Stefan Metzmacher1-2/+2
Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
2025-04-18s4:client: remove unused ports from cifsdd* functionsStefan Metzmacher3-11/+7
Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
2025-04-18s4:libcli: remove unused ports from smbcli_full_connection()Stefan Metzmacher2-2/+2
Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
2025-04-18s4:client: remove unused destports from do_message_op()Stefan Metzmacher1-2/+2
Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
2025-04-18s4:libcli: remove unused ports from smbcli_socket_connect()Stefan Metzmacher1-1/+1
Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
2025-02-27smbclient: report kilobytes per second as kB/s, not kb/sDouglas Bagnall1-2/+2
https://bugzilla.samba.org/show_bug.cgi?id=11023 Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
2024-10-24s4:client: Fix memory leaks in smblcient4Andreas Schneider1-15/+21
==375711==ERROR: LeakSanitizer: detected memory leaks Direct leak of 20 byte(s) in 1 object(s) allocated from: #0 0x7f83838f6880 in strdup ../../../../libsanitizer/asan/asan_interceptors.cpp:578 #1 0x55a06cc7c244 in main ../../source4/client/client.c:3470 #2 0x7f837fe2a2ad in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Martin Schwenke <martin@meltin.net>
2024-10-24s4:client: Remove trailing spaces in client.cAndreas Schneider1-229/+229
Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Martin Schwenke <martin@meltin.net>
2024-04-23s4:lib/tls: add support for ↵Stefan Metzmacher1-0/+4
gnutls_certificate_set_x509_{system_trust,trust_dir}() Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2024-03-27Add simple http_client for use in black box tests (in following commits)Noel Power1-0/+401
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15611 Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2023-09-11s4:client: Fix code spellingJoseph Sutton1-1/+1
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2023-08-08s4:client: Add missing newlines to logging messagesJoseph Sutton2-4/+4
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2023-08-03s4:client: Fix code spellingAndreas Schneider1-1/+1
Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Joseph Sutton <josephsutton@catalyst.net.nz>
2022-08-22s4:client: Fix shellcheck errors in test_smbclient.shAndreas Schneider1-3/+3
source4/client/tests/test_smbclient.sh:31:99: error: Double quote array expansions to avoid re-splitting elements. [SC2068] source4/client/tests/test_smbclient.sh:41:116: error: Double quote array expansions to avoid re-splitting elements. [SC2068] source4/client/tests/test_smbclient.sh:43:94: error: Double quote array expansions to avoid re-splitting elements. [SC2068] Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Pavel Filipenský <pfilipensky@samba.org>
2022-07-08s4:client: Reformat shell scriptsAndreas Schneider2-88/+91
shfmt -f source4/client/ | xargs shfmt -w -p -i 0 -fn Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Pavel Filipenský <pfilipensky@samba.org>
2022-02-17source4/torture: Drop unused variable attributeMartin Schwenke1-4/+0
clang complains: ../../source4/client/client.c:1569:11: error: variable 'attribute' set but not used [-Werror,-Wunused-but-set-variable] uint16_t attribute = FILE_ATTRIBUTE_SYSTEM | FILE_ATTRIBUTE_HIDDEN; ^ That is, the variable is initialised and updated but the value is never used. Commit 2f377d5101783ed4d8c96a46aaec61895cc7b6ad from 2004 dropped the use of this variable. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Thu Feb 17 19:06:25 UTC 2022 on sn-devel-184
2021-09-10s4/cifsdd: don't ignore unknown optionsRalph Boehme1-1/+7
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14828 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
2021-09-10s4/smbclient: don't ignore unknown optionsRalph Boehme1-0/+5
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14828 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
2021-06-16s4:client: Migrate cifsdd to new cmdline option parserAndreas Schneider2-13/+42
Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2021-06-16testprogs: Use new kerberos options for smbclient(4) testsAndreas Schneider1-1/+1
Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2021-06-16s4:client: Migrate smbclient4 to new cmdline option parserAndreas Schneider1-18/+42
Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2021-06-16s4:client: Use a creds helper variableAndreas Schneider1-5/+10
Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2021-04-13s4:client:tests: create temporary files under $PREFIX/SELFTEST_TMPDIRStefan Metzmacher2-23/+25
Tests should not create files in the build nor the source directory! Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
2021-03-16lib: Remove init_names()Volker Lendecke1-2/+0
is_myname() looks at lp_* directly, nmbd maintains its own list: We don't need the baroque loadparm handler anymore. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2020-08-28lib/util: remove extra safe_string.h fileMatthew DeVore1-0/+2
lib/util/safe_string.h is similar to source3/include/safe_string.h, but the former has fewer checks. It is missing bcopy, strcasecmp, and strncasecmp. Add the missing elements to lib/util/safe_string.h remove the other safe_string.h which is in the source3-specific path. To accomodate existing uses of str(n?)casecmp, add #undef lines to source files where they are used. Signed-off-by: Matthew DeVore <matvore@google.com> Reviewed-by: David Mulder <dmulder@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Fri Aug 28 02:18:40 UTC 2020 on sn-devel-184
2020-07-16s4:client: Remove code inside #ifdef NEXT2Christof Schmitt1-5/+0
This is dead code, the define is never set. Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
2020-05-08Fix clang 9 missing-field-initializer warningsGary Lockyer1-1/+1
Signed-off-by: Gary Lockyer <gary@catalyst.net.nz> Reviewed-by: Andreas Schneider <asn@samba.org>
2020-02-10smbclient4: Remove unused codeVolker Lendecke1-809/+0
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Mon Feb 10 19:26:37 UTC 2020 on sn-devel-184
2019-08-22s4: free popt context in clientSwen Schillig1-0/+2
If done with popt context it should be free'd. Signed-off-by: Swen Schillig <swen@linux.ibm.com> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
2019-01-28s4:cifsdd: Use C99 initializers for cifsdd argdefAndreas Schneider1-11/+55
Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2019-01-28s4:client: Use C99 initializer for poptOption in cifsddAndreas Schneider1-5/+21
Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2019-01-28s4:client: Use C99 initializer for poptOption in clientAndreas Schneider1-9/+71
Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
2018-04-03s4:client: Fix size types and loopAndreas Schneider1-5/+3
This fixes compilation with -Wstrict-overflow=2. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2018-03-20s4:client: Fix size typesAndreas Schneider1-4/+4
This fixes compilation with -Wstrict-overflow=2 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2017-05-13s4: cifsdd: Allocate the event context off NULL, not talloc_autofree_context().Jeremy Allison1-2/+8
Ensure it's freed on exit paths. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
2017-05-13s4: client: Allocate event context off struct smbclient_context *, not ↵Jeremy Allison1-1/+1
talloc_autofree_context(). Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
2017-05-11s4: popt: Global replace of cmdline_credentials -> ↵Jeremy Allison2-10/+17
popt_get_cmdline_credentials(). Add one use of popt_set_cmdline_credentials(). Fix 80 column limits when cmdline_credentials changes to popt_get_cmdline_credentials(). Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
2017-02-15lib: Fix "is_case_sensitive" in "ms_fnmatch_protocol"' callersVolker Lendecke1-16/+6
In the optimization in f969be54417 I got the boolean flag "is_case_sensitive" wrong. The behaviour was case *insensitive*, so all the flags should have been "false", keeping the old behaviour. While there, simplify "mask_match" in source4 client.c Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Wed Feb 15 11:40:32 CET 2017 on sn-devel-144
2017-01-22lib: Add "is_case_sensitive" to ms_fnmatch_protocolVolker Lendecke1-3/+5
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
2016-12-11smbclient4: xfile->stdioVolker Lendecke1-15/+15
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2016-12-01smbclient: fix string formatting in print commandDouglas Bagnall1-6/+17
At one time, the variables lname and rname were char arrays, but now they are pointers. When they were arrays, sizeof(rname) was the length of the array, but now it gives the size of the pointer which is not what we want. In the case where the filename is -, rname was alloced as size 1, which could never fit the name it wanted to have contain ("stdin-<pid>"). Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Jeremy Allison <jra@samba.org>
2016-05-13s4:client: fix O3 error unused result of of chdir and systemMichael Adam1-5/+27
Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Christian Ambach <ambi@samba.org>
2016-03-10s4/client/cifsdd.c: typoAurelien Aptel1-1/+1
Signed-off-by: Aurelien Aptel <aaptel@suse.com> Reviewed-by: Jeremy Allison <jra@samba.org> Reviewed-by: Uri Simchoni <uri@samba.org>
2016-02-18s4-client: Fix cifsdd arg parsing for skipAndreas Schneider1-1/+1
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11730 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
generated by cgit v1.2.3 (git 2.25.1) at 2026-05-06 20:01:23 +0000