1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
|
# Unix SMB/CIFS implementation.
# Copyright (C) Martin Kraemer 2019 <mk.maddin@gmail.com>
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
#
import os
from samba.tests.samba_tool.base import SambaToolCmdTest
import re
class DSaclSetSddlTestCase(SambaToolCmdTest):
"""Tests for samba-tool dsacl set --sddl subcommand"""
sddl = "(OA;CIIO;RPWP;aaaaaaaa-1111-bbbb-2222-dddddddddddd;33333333-eeee-4444-ffff-555555555555;PS)"
sddl_lc = "(OA;CIIO;RPWP;aaaaaaaa-1111-bbbb-2222-dddddddddddd;33333333-eeee-4444-ffff-555555555555;PS)"
sddl_uc = "(OA;CIIO;RPWP;AAAAAAAA-1111-BBBB-2222-DDDDDDDDDDDD;33333333-EEEE-4444-FFFF-555555555555;PS)"
sddl_sid = "(OA;CIIO;RPWP;aaaaaaaa-1111-bbbb-2222-dddddddddddd;33333333-eeee-4444-ffff-555555555555;S-1-5-10)"
sddl_multi = "(OA;CIIO;RPWP;aaaaaaaa-1111-bbbb-2222-dddddddddddd;33333333-eeee-4444-ffff-555555555555;PS)(OA;CIIO;RPWP;cccccccc-9999-ffff-8888-eeeeeeeeeeee;77777777-dddd-6666-bbbb-555555555555;PS)"
def setUp(self):
super().setUp()
self.samdb = self.getSamDB("-H", "ldap://%s" % os.environ["DC_SERVER"],"-U%s%%%s" % (os.environ["DC_USERNAME"], os.environ["DC_PASSWORD"]))
self.dn="OU=DSaclSetSddlTestCase,%s" % self.samdb.domain_dn()
self.samdb.create_ou(self.dn)
def tearDown(self):
super().tearDown()
# clean-up the created test ou
self.samdb.delete(self.dn)
def test_sddl(self):
"""Tests if a sddl string can be added 'the normal way'"""
(result, out, err) = self.runsubcmd("dsacl", "set","--objectdn=%s" % self.dn, "--sddl=%s" % self.sddl)
self.assertCmdSuccess(result, out, err)
self.assertEqual(err, "", "Shouldn't be any error messages")
#extract only the two sddl strings from samba-tool output
acl_list=re.findall('.*descriptor for.*:\n(.*?)\n',out)
self.assertNotEqual(acl_list[0], acl_list[1], "new and old SDDL string differ")
self.assertMatch(acl_list[1], self.sddl, "new SDDL string should be contained within second sddl output")
def test_sddl_set_get(self):
"""Tests if a sddl string can be added 'the normal way' and the output of 'get' is the same"""
(result, out, err) = self.runsubcmd("dsacl", "get",
"--objectdn=%s" % self.dn)
self.assertCmdSuccess(result, out, err)
self.assertEqual(err, "", "Shouldn't be any error messages")
#extract only the two sddl strings from samba-tool output
acl_list_get=re.findall('^descriptor for.*:\n(.*?)\n', out)
(result, out, err) = self.runsubcmd("dsacl", "set",
"--objectdn=%s" % self.dn,
"--sddl=%s" % self.sddl)
self.assertCmdSuccess(result, out, err)
self.assertEqual(err, "", "Shouldn't be any error messages")
#extract only the two sddl strings from samba-tool output
acl_list_old=re.findall('old descriptor for.*:\n(.*?)\n', out)
self.assertEqual(acl_list_old, acl_list_get,
"output of dsacl get should be the same as before set")
acl_list=re.findall('new descriptor for.*:\n(.*?)\n', out)
(result, out, err) = self.runsubcmd("dsacl", "get",
"--objectdn=%s" % self.dn)
self.assertCmdSuccess(result, out, err)
self.assertEqual(err, "", "Shouldn't be any error messages")
#extract only the two sddl strings from samba-tool output
acl_list_get2=re.findall('^descriptor for.*:\n(.*?)\n', out)
self.assertEqual(acl_list, acl_list_get2,
"output of dsacl get should be the same as after set")
def test_multisddl(self):
"""Tests if we can add multiple, different sddl strings at the same time"""
(result, out, err) = self.runsubcmd("dsacl", "set","--objectdn=%s" % self.dn, "--sddl=%s" % self.sddl_multi)
self.assertCmdSuccess(result, out, err)
self.assertEqual(err, "", "Shouldn't be any error messages")
#extract only the two sddl strings from samba-tool output
acl_list=re.findall('.*descriptor for.*:\n(.*?)\n',out)
for ace in re.findall(r'\(.*?\)',self.sddl_multi):
self.assertMatch(acl_list[1], ace, "new SDDL string should be contained within second sddl output")
def test_duplicatesddl(self):
"""Tests if an already existing sddl string can be added causing duplicate entry"""
acl_list = self._double_sddl_check(self.sddl,self.sddl)
self.assertEqual(acl_list[0],acl_list[1])
def test_casesensitivesddl(self):
"""Tests if an already existing sddl string can be added in different cases causing duplicate entry"""
acl_list = self._double_sddl_check(self.sddl_lc,self.sddl_uc)
self.assertEqual(acl_list[0],acl_list[1])
def test_sidsddl(self):
"""Tests if an already existing sddl string can be added with SID instead of SDDL SIDString causing duplicate entry"""
acl_list = self._double_sddl_check(self.sddl,self.sddl_sid)
self.assertEqual(acl_list[0],acl_list[1])
def test_twosddl(self):
"""Tests if an already existing sddl string can be added by using it twice/in combination with non existing sddl string causing duplicate entry"""
acl_list = self._double_sddl_check(self.sddl,self.sddl + self.sddl)
self.assertEqual(acl_list[0],acl_list[1])
def _double_sddl_check(self,sddl1,sddl2):
"""Adds two sddl strings and checks if there was an ace change after the second adding"""
(result, out, err) = self.runsubcmd("dsacl", "set","--objectdn=%s" % self.dn, "--sddl=%s" % sddl1)
self.assertCmdSuccess(result, out, err)
self.assertEqual(err, "", "Shouldn't be any error messages")
acl_list = re.findall('.*descriptor for.*:\n(.*?)\n',out)
self.assertMatch(acl_list[1], sddl1, "new SDDL string should be contained within second sddl output - is not")
#add sddl2
(result, out, err) = self.runsubcmd("dsacl", "set","--objectdn=%s" % self.dn, "--sddl=%s" % sddl2)
self.assertCmdSuccess(result, out, err)
self.assertEqual(err, "", "Shouldn't be any error messages")
acl_list = re.findall('.*descriptor for.*:\n(.*?)\n',out)
return acl_list
def test_add_delete_sddl(self):
"""Tests if a sddl string can be added 'the normal way', deleted and
final state is the same as initial.
"""
(result, out, err) = self.runsubcmd("dsacl", "get",
"--objectdn=%s" % self.dn)
self.assertCmdSuccess(result, out, err)
self.assertEqual(err, "", "Shouldn't be any error messages")
# extract only the two sddl strings from samba-tool output
acl_list_orig = re.findall('^descriptor for.*:\n(.*?)\n', out)[0]
(result, out, err) = self.runsubcmd("dsacl", "set",
"--objectdn=%s" % self.dn,
"--sddl=%s" % self.sddl)
self.assertCmdSuccess(result, out, err)
self.assertEqual(err, "", "Shouldn't be any error messages")
acl_list_added = re.findall('new descriptor for.*:\n(.*?)\n', out)[0]
self.assertNotEqual(acl_list_added, acl_list_orig, "After adding the SD should be different.")
self.assertMatch(acl_list_added, self.sddl, "The added ACE should be part of the new SD.")
(result, out, err) = self.runsubcmd("dsacl", "delete",
"--objectdn=%s" % self.dn,
"--sddl=%s" % self.sddl)
self.assertCmdSuccess(result, out, err)
self.assertEqual(err, "", "Shouldn't be any error messages")
acl_list_final = re.findall('new descriptor for.*:\n(.*?)\n', out)[0]
self.assertEqual(acl_list_orig, acl_list_final,
"output of dsacl delete should be the same as before adding")
(result, out, err) = self.runsubcmd("dsacl", "get",
"--objectdn=%s" % self.dn)
self.assertCmdSuccess(result, out, err)
self.assertEqual(err, "", "Shouldn't be any error messages")
# extract only the two sddl strings from samba-tool output
acl_list_final_get = re.findall('^descriptor for.*:\n(.*?)\n', out)[0]
self.assertEqual(acl_list_orig, acl_list_final_get,
"output of dsacl get should be the same as after adding and deleting again")
def test_delete(self):
# add sddl_multi first
(result, out, err) = self.runsubcmd("dsacl", "set",
"--objectdn=%s" % self.dn,
"--sddl=%s" % self.sddl_multi)
self.assertCmdSuccess(result, out, err)
self.assertEqual(err, "", "Shouldn't be any error messages")
# delete sddl
(result, out, err) = self.runsubcmd("dsacl", "delete",
"--objectdn=%s" % self.dn,
"--sddl=%s" % self.sddl)
self.assertCmdSuccess(result, out, err)
self.assertEqual(err, "", "Shouldn't be any error messages")
acl_list_deleted = re.findall('new descriptor for.*:\n(.*?)\n', out)[0]
self.assertNotRegex(acl_list_deleted, re.escape(self.sddl))
left_sddl = self.sddl_multi.replace(self.sddl, "")
self.assertRegex(acl_list_deleted, re.escape(left_sddl))
def test_delete_twice(self):
"""Tests if deleting twice the same ACEs returns the expected warning."""
# add sddl_multi first
(result, out, err) = self.runsubcmd("dsacl", "set",
"--objectdn=%s" % self.dn,
"--sddl=%s" % self.sddl_multi)
self.assertCmdSuccess(result, out, err)
self.assertEqual(err, "", "Shouldn't be any error messages")
# delete sddl
(result, out, err) = self.runsubcmd("dsacl", "delete",
"--objectdn=%s" % self.dn,
"--sddl=%s" % self.sddl)
self.assertCmdSuccess(result, out, err)
self.assertEqual(err, "", "Shouldn't be any error messages")
# delete sddl_multi
(result, out, err) = self.runsubcmd("dsacl", "delete",
"--objectdn=%s" % self.dn,
"--sddl=%s" % self.sddl_multi)
self.assertCmdSuccess(result, out, err)
self.assertEqual(err, "", "Shouldn't be any error messages")
self.assertRegex(out, "WARNING", "Should throw a warning about deleting non existent ace.")
warn = re.findall("WARNING: (.*?)\n", out)[0]
left_sddl = self.sddl_multi.replace(self.sddl, "")
self.assertRegex(warn, re.escape(self.sddl), "Should point out the non existent ace.")
self.assertNotRegex(warn, re.escape(left_sddl),
"Should not complain about all aces, since one of them is not deleted twice.")
|
